VolkerE has uploaded a new change for review.
https://gerrit.wikimedia.org/r/227582
Change subject: Make use of HTML5 sectioning elements
......................................................................
Make use of HTML5 sectioning elements
Blueprint should make use of HTML5 sectioning elements `header` and `main`
including the corresponding ARIA roles
Bug: T107213
Change-Id: Ice6b718df5eb4bd28020f2db407d406050e6249f
---
M templates/Skin.php
M templates/Skin.template
2 files changed, 10 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Blueprint
refs/changes/82/227582/1
diff --git a/templates/Skin.php b/templates/Skin.php
index 0035c42..82a8602 100644
--- a/templates/Skin.php
+++ b/templates/Skin.php
@@ -29,6 +29,7 @@
'partials' => array(),
'scopes' => array(),
'sp_vars' => array('root' => $in),
+ 'lcrun' => 'LCRun3',
'funcs' => array(
'v' => function ($cx, $base, $path) {
$count = count($cx['scopes']);
@@ -63,7 +64,7 @@
case -1:
$base = $cx['sp_vars']['root'];
break;
- case -2;
+ case -2:
return null;
default:
$base = $cx['scopes'][$count];
@@ -230,7 +231,7 @@
';}).' </ul>
'.'</div>
- <nav class="navbar navbar-fixed-top">
+ <header class="navbar navbar-fixed-top" role="banner">
<div class="container-fluid">
<div class="navbar-header">
<ul class="nav navbar-nav navbar-head" >
@@ -266,9 +267,8 @@
</div>
</div>
</div>
- </nav>
-
- <div class="container" id="content">
+ </header>
+ <main class="container" id="content" role="main">
<h1 class="firstHeading" id="firstHeading">
'.$cx['funcs']['v']($cx, $in, array('title')).'
</h1>
@@ -284,8 +284,7 @@
'.(($cx['funcs']['ifvar']($cx, $cx['funcs']['v']($cx, $in,
array('printfooter')))) ? ' <div class="printfooter">
'.$cx['funcs']['v']($cx, $in,
array('printfooter')).'
</div>
-' : '').' </div>
-
+' : '').' </main>
</body>
'.$cx['funcs']['v']($cx, $in, array('debughtml')).'
'.$cx['funcs']['v']($cx, $in, array('bottomscripts')).'
diff --git a/templates/Skin.template b/templates/Skin.template
index bf62a20..cfc11a9 100755
--- a/templates/Skin.template
+++ b/templates/Skin.template
@@ -4,7 +4,7 @@
{{>sidebar}}
</div>
- <nav class="navbar navbar-fixed-top">
+ <header class="navbar navbar-fixed-top" role="banner">
<div class="container-fluid">
<div class="navbar-header">
<ul class="nav navbar-nav navbar-head" >
@@ -48,9 +48,8 @@
</div>
</div>
</div>
- </nav>
-
- <div class="container" id="content">
+ </header>
+ <main class="container" id="content" role="main">
<h1 class="firstHeading" id="firstHeading">
{{{title}}}
</h1>
@@ -74,8 +73,7 @@
{{{printfooter}}}
</div>
{{/if}}
- </div>
-
+ </main>
</body>
{{{debughtml}}}
{{{bottomscripts}}}
--
To view, visit https://gerrit.wikimedia.org/r/227582
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice6b718df5eb4bd28020f2db407d406050e6249f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Blueprint
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
