Dduvall has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227584

Change subject: QA: Upgrade MW-Selenium to 1.5 for video recording support
......................................................................

QA: Upgrade MW-Selenium to 1.5 for video recording support

DO NOT MERGE YET. Simulating failure to test the recording

Change-Id: I444678d39078e438985a0ab372ef7104f31bf669
---
M Gemfile
M Gemfile.lock
M tests/browser/features/diff.feature
M tests/browser/features/step_definitions/common_steps.rb
4 files changed, 12 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/84/227584/1

diff --git a/Gemfile b/Gemfile
index 88ac589..06d966a 100644
--- a/Gemfile
+++ b/Gemfile
@@ -5,5 +5,5 @@
 
 gem 'chunky_png'
 gem 'jsduck'
-gem 'mediawiki_selenium', '~> 1.4.0'
+gem 'mediawiki_selenium', '~> 1.5.0'
 gem 'rubocop', require: false
diff --git a/Gemfile.lock b/Gemfile.lock
index 8b16ba3..1c3e4ab 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -28,10 +28,10 @@
     faraday-cookie_jar (0.0.6)
       faraday (>= 0.7.4)
       http-cookie (~> 1.0.0)
-    ffi (1.9.9)
+    ffi (1.9.10)
     gherkin (2.12.2)
       multi_json (~> 1.3)
-    headless (1.0.2)
+    headless (2.1.0)
     http-cookie (1.0.2)
       domain_name (~> 0.5)
     i18n (0.7.0)
@@ -45,9 +45,9 @@
     mediawiki_api (0.4.1)
       faraday (~> 0.9, >= 0.9.0)
       faraday-cookie_jar (~> 0.0, >= 0.0.6)
-    mediawiki_selenium (1.4.0)
+    mediawiki_selenium (1.5.0)
       cucumber (~> 1.3, >= 1.3.20)
-      headless (~> 1.0, >= 1.0.1)
+      headless (~> 2.0, >= 2.1.0)
       json (~> 1.8, >= 1.8.1)
       mediawiki_api (~> 0.4, >= 0.4.1)
       page-object (~> 1.0)
@@ -56,7 +56,7 @@
       syntax (~> 1.2, >= 1.2.0)
       thor (~> 0.19, >= 0.19.1)
     mime-types (2.6.1)
-    multi_json (1.11.1)
+    multi_json (1.11.2)
     multi_test (0.1.2)
     multipart-post (2.0.0)
     netrc (0.10.3)
@@ -108,5 +108,5 @@
 DEPENDENCIES
   chunky_png
   jsduck
-  mediawiki_selenium (~> 1.4.0)
+  mediawiki_selenium (~> 1.5.0)
   rubocop
diff --git a/tests/browser/features/diff.feature 
b/tests/browser/features/diff.feature
index 168fe83..9552cf4 100644
--- a/tests/browser/features/diff.feature
+++ b/tests/browser/features/diff.feature
@@ -13,3 +13,4 @@
       And I open the latest diff
     Then I should see "GHI" as added content
       And I should see "DEF" as removed content
+      And FAIL
diff --git a/tests/browser/features/step_definitions/common_steps.rb 
b/tests/browser/features/step_definitions/common_steps.rb
index 996885e..72a596e 100644
--- a/tests/browser/features/step_definitions/common_steps.rb
+++ b/tests/browser/features/step_definitions/common_steps.rb
@@ -105,3 +105,7 @@
   # FIXME: Switch to link_element when red links move to stable
   expect(on(ArticlePage).content_wrapper_element.link_element(text: 
text).when_present(10)).to be_visible
 end
+
+Then(/^FAIL$/) do
+  expect(true).to be false
+end

-- 
To view, visit https://gerrit.wikimedia.org/r/227584
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I444678d39078e438985a0ab372ef7104f31bf669
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Dduvall <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to