Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227673

Change subject: Improve getentities XML test
......................................................................

Improve getentities XML test

Change-Id: I52ffb38855e946a741b1ce9e72d4e28b0b1b8ffd
---
M repo/tests/phpunit/data/api/getentities.xml
M repo/tests/phpunit/includes/api/ApiXmlFormatTest.php
2 files changed, 22 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/73/227673/1

diff --git a/repo/tests/phpunit/data/api/getentities.xml 
b/repo/tests/phpunit/data/api/getentities.xml
index e1b1196..4ecdf20 100644
--- a/repo/tests/phpunit/data/api/getentities.xml
+++ b/repo/tests/phpunit/data/api/getentities.xml
@@ -2,9 +2,20 @@
 <api success="1">
        <entities>
                <entity type="item" id="$itemIdUnderTest">
-                       <labels/>
-                       <descriptions/>
-                       <aliases/>
+                       <labels>
+                               <label language="en" value="en-label"/>
+                               <label language="de" value="de-label"/>
+                       </labels>
+                       <descriptions>
+                               <description language="de" value="de-desc"/>
+                               <description language="es" value="es-desc"/>
+                       </descriptions>
+                       <aliases>
+                               <alias language="pt" value="AA"/>
+                               <alias language="pt" value="BB"/>
+                               <alias language="en" value="AA-en"/>
+                               <alias language="en" value="BB-en"/>
+                       </aliases>
                        <claims>
                                <property id="$propertyIdUnderTest">
                                        <claim _idx="0" type="statement" 
id="$itemIdUnderTest$1111AAAA-43cb-ed6d-3adb-760e85bd17ee" rank="normal">
diff --git a/repo/tests/phpunit/includes/api/ApiXmlFormatTest.php 
b/repo/tests/phpunit/includes/api/ApiXmlFormatTest.php
index ee90ddf..b34a94e 100644
--- a/repo/tests/phpunit/includes/api/ApiXmlFormatTest.php
+++ b/repo/tests/phpunit/includes/api/ApiXmlFormatTest.php
@@ -360,6 +360,14 @@
                $snak = new PropertyNoValueSnak( $propertyId );
                $guid = $item->getId()->getSerialization() . 
'$1111AAAA-43cb-ed6d-3adb-760e85bd17ee';
                $item->getStatements()->addNewStatement( $snak, null, null, 
$guid );
+
+               $item->setLabel( 'en', 'en-label' );
+               $item->setLabel( 'de', 'de-label' );
+               $item->setDescription( 'de', 'de-desc' );
+               $item->setDescription( 'es', 'es-desc' );
+               $item->setAliases( 'pt', array( 'AA', 'BB' ) );
+               $item->setAliases( 'en', array( 'AA-en', 'BB-en' ) );
+
                $entityRevision = $store->saveEntity( $item, 'testing more!', 
$wgUser );
 
                return $entityRevision;

-- 
To view, visit https://gerrit.wikimedia.org/r/227673
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I52ffb38855e946a741b1ce9e72d4e28b0b1b8ffd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to