jenkins-bot has submitted this change and it was merged.

Change subject: Add Content-Length header to thumb.php redirects
......................................................................


Add Content-Length header to thumb.php redirects

Without the Content-Length header, the response is sent with
Transfer-Encoding: Chunked, which is somehow mangled by
mod_fastcgi. Varnish then claims the response is malformed and declines
to process it, sending the client a 503 instead.

This is a followup of 0ee9e717f49b9e15bd63fd66f3d0967939c35b05

Bug: T84842
Change-Id: Ia610a43789e6ff14cfc0964f285bbec39c890152
---
M thumb.php
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Alex Monk: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/thumb.php b/thumb.php
index 3b7ff43..03a3f35 100644
--- a/thumb.php
+++ b/thumb.php
@@ -213,6 +213,7 @@
                        if ( count( $varyHeader ) ) {
                                $response->header( 'Vary: ' . implode( ', ', 
$varyHeader ) );
                        }
+                       $response->header( 'Content-Length: 0' );
                        return;
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/227676
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia610a43789e6ff14cfc0964f285bbec39c890152
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to