Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/227771

Change subject: Keep Wikipedia enums and constructors
......................................................................

Keep Wikipedia enums and constructors

The previous ProGuard configuration specified that all Wikipedia classes
and interfaces should be kept but said nothing of enums. This patch
includes enums and also specifies that constructors be kept for all
three, as documentation isn't clear if wildcards include constructors.

Change-Id: Ia286b74668a5d07b306772c43e34772709e5e632
---
M wikipedia/proguard-rules.pro
1 file changed, 3 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/71/227771/1

diff --git a/wikipedia/proguard-rules.pro b/wikipedia/proguard-rules.pro
index b0e4737..1aae4c9 100644
--- a/wikipedia/proguard-rules.pro
+++ b/wikipedia/proguard-rules.pro
@@ -83,5 +83,7 @@
 
 ###
 # Our code:
--keep class org.wikipedia.** {*;}
+-keep class org.wikipedia.** { <init>(...); *; }
+-keep enum org.wikipedia.** { <init>(...); *; }
 -keep class org.mediawiki.api.json.** {*;}
+-keep enum org.wikipedia.api.json.** { <init>(...); *; }

-- 
To view, visit https://gerrit.wikimedia.org/r/227771
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia286b74668a5d07b306772c43e34772709e5e632
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to