jenkins-bot has submitted this change and it was merged.
Change subject: Use frameless buttons in mobile process dialogs
......................................................................
Use frameless buttons in mobile process dialogs
Change-Id: I6eb1baf8f0189374bc30aebd98fc322f7fcee223
---
M src/ui/windowmanagers/ve.ui.MobileWindowManager.js
1 file changed, 19 insertions(+), 0 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ui/windowmanagers/ve.ui.MobileWindowManager.js
b/src/ui/windowmanagers/ve.ui.MobileWindowManager.js
index b9519dc..a7f2406 100644
--- a/src/ui/windowmanagers/ve.ui.MobileWindowManager.js
+++ b/src/ui/windowmanagers/ve.ui.MobileWindowManager.js
@@ -19,6 +19,9 @@
// Parent constructor
ve.ui.MobileWindowManager.super.call( this, surface, config );
+ // Events
+ this.connect( this, { opening: 'onMobileOpening' } );
+
// Initialization
this.$element.addClass( 've-ui-mobileWindowManager' );
};
@@ -38,3 +41,19 @@
ve.ui.MobileWindowManager.static.defaultSize = 'full';
/* Methods */
+
+/**
+ * Handle window opening events
+ */
+ve.ui.MobileWindowManager.prototype.onMobileOpening = function ( win, opening
) {
+ // HACK: un-frame buttons
+ opening.done( function () {
+ var i, l, list;
+ if ( win instanceof OO.ui.ProcessDialog ) {
+ list = win.actions.list;
+ for ( i = 0, l = list.length; i < l; i++ ) {
+ list[i].toggleFramed( false );
+ }
+ }
+ } );
+};
--
To view, visit https://gerrit.wikimedia.org/r/227991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6eb1baf8f0189374bc30aebd98fc322f7fcee223
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
