jenkins-bot has submitted this change and it was merged.
Change subject: MediaWiki, Apex themes: Fix height of frameless toolbar button
......................................................................
MediaWiki, Apex themes: Fix height of frameless toolbar button
Use line-height to define the height in one rule, instead of adding
font height and padding which leads to compound rounding errors.
Change-Id: I48cad2bcd635ab1ea82c520255dc5441c9cc6d2d
---
M src/themes/apex/tools.less
M src/themes/mediawiki/tools.less
2 files changed, 4 insertions(+), 3 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/themes/apex/tools.less b/src/themes/apex/tools.less
index ca78a57..1cc7326 100644
--- a/src/themes/apex/tools.less
+++ b/src/themes/apex/tools.less
@@ -25,9 +25,10 @@
margin: 0;
> .oo-ui-buttonElement-button {
margin: 0;
- padding: 1.1953125em 0.3125em;
+ padding: 0 0.3125em;
> .oo-ui-labelElement-label {
margin: 0 1em;
+ line-height: 3.40625em; /*
43/12.8 */
}
}
}
diff --git a/src/themes/mediawiki/tools.less b/src/themes/mediawiki/tools.less
index 1043946..14caccf 100644
--- a/src/themes/mediawiki/tools.less
+++ b/src/themes/mediawiki/tools.less
@@ -30,11 +30,11 @@
border: 0;
border-radius: 0;
margin: 0;
- padding: 1.0546875em 0.3125em;
+ padding: 0 0.3125em;
> .oo-ui-labelElement-label {
margin: 0 1em;
- line-height: inherit;
+ line-height: 3.125em; /* 40/12.8 */
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/227982
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I48cad2bcd635ab1ea82c520255dc5441c9cc6d2d
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
