Faidon Liambotis has submitted this change and it was merged.
Change subject: git: remove out-of-sync alert
......................................................................
git: remove out-of-sync alert
Puppet is not a monitoring system and alerts have no place in puppet
runs.
Change-Id: I3c056f2af773a258c9be7b07786f57fdd25c30dc
---
M modules/git/manifests/install.pp
1 file changed, 0 insertions(+), 26 deletions(-)
Approvals:
Faidon Liambotis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/git/manifests/install.pp b/modules/git/manifests/install.pp
index 34de680..2b0d1e5 100644
--- a/modules/git/manifests/install.pp
+++ b/modules/git/manifests/install.pp
@@ -34,12 +34,6 @@
# Specifies a file on disk whose presence will cause the repository to
# hold at the last specified tag
#
-# NOTE: If the lock file exists and the tag on disk does not match
-# the current tag in Puppet a notice will be thrown.
-#
-# Example:
-# <path_to_repo> is out of sync with upstream tag <tag_in_puppet>
-#
# === Example usage
#
# git::install { 'project/name/on/gerrit':
@@ -79,26 +73,6 @@
owner => $owner,
group => $group,
require => Git::Clone[$title]
- }
- }
-
- if ($lock_file) {
-
- exec {"${title}_confirm_tag_version":
- command => '/bin/true',
- cwd => $directory,
- user => $owner,
- unless => "git diff HEAD..${git_tag} --exit-code",
- path => '/usr/bin/:bin',
- logoutput => false,
- notify => Exec["${title}_alert_for_out_of_sync"],
- }
-
- exec { "${title}_alert_for_out_of_sync":
- command => "/bin/echo ${directory} is out of sync with
upstream tag ${git_tag}",
- logoutput => true,
- before => Exec["git_update_${title}"],
- refreshonly => true,
}
}
--
To view, visit https://gerrit.wikimedia.org/r/228143
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c056f2af773a258c9be7b07786f57fdd25c30dc
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
