Hoo man has uploaded a new change for review.
https://gerrit.wikimedia.org/r/228755
Change subject: Fix maintenance/update.php on SQLite client wikis
......................................................................
Fix maintenance/update.php on SQLite client wikis
That update has no effect on SQLite anyway, so don't even
try to run it there.
Change-Id: I1c865195174a64060ecd06ca143010da201b6478
---
M client/includes/Usage/Sql/SqlUsageTrackerSchemaUpdater.php
1 file changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/55/228755/1
diff --git a/client/includes/Usage/Sql/SqlUsageTrackerSchemaUpdater.php
b/client/includes/Usage/Sql/SqlUsageTrackerSchemaUpdater.php
index 745482a..a25e40f 100644
--- a/client/includes/Usage/Sql/SqlUsageTrackerSchemaUpdater.php
+++ b/client/includes/Usage/Sql/SqlUsageTrackerSchemaUpdater.php
@@ -63,8 +63,11 @@
array( __CLASS__, 'fillUsageTable' ),
) );
} else {
- $script = $this->getUpdateScriptPath(
'entity_usage-alter-aspect-varbinary-37', $db->getType() );
- $this->dbUpdater->modifyExtensionField( $table,
'eu_aspect', $script );
+ // This update is neither needed on SQLite nor does it
work there.
+ if ( $db->getType() !== 'sqlite' ) {
+ $script = $this->getUpdateScriptPath(
'entity_usage-alter-aspect-varbinary-37', $db->getType() );
+ $this->dbUpdater->modifyExtensionField( $table,
'eu_aspect', $script );
+ }
$script = $this->getUpdateScriptPath(
'entity_usage-add-touched', $db->getType() );
$this->dbUpdater->addExtensionField( $table,
'eu_touched', $script );
--
To view, visit https://gerrit.wikimedia.org/r/228755
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1c865195174a64060ecd06ca143010da201b6478
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
