Florianschmidtwelzow has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/228778

Change subject: Move ext-mbstring to require section in composer.json
......................................................................

Move ext-mbstring to require section in composer.json

Moved from suggest. mb_* functions are used in HtmlFormatter, which
is used in:
 - ApiHelp
 - CirrusSearch
 - TextExtracts
 - MobileFrontend

Instead of suggesting a package to be installed 8which doesn't help
users using mediawiki/vendor or a tarball release[1], moving ext-mbstring
to the require section in te composer.json to be always available,
if needed.

[1] These users most likely don't have the ability to install and/or enable
php modules.

Bug: T62174
Change-Id: I0ade7498508d78706b8d1ccc902ce636951274bb
---
M composer.json
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/78/228778/1

diff --git a/composer.json b/composer.json
index 00411a9..6d539c5 100644
--- a/composer.json
+++ b/composer.json
@@ -18,6 +18,7 @@
        "require": {
                "cssjanus/cssjanus": "1.1.1",
                "ext-iconv": "*",
+               "ext-mbstring": "*",
                "leafo/lessphp": "0.5.0",
                "liuggio/statsd-php-client": "1.0.16",
                "mediawiki/at-ease": "1.0.0",
@@ -40,7 +41,6 @@
        "suggest": {
                "ext-fileinfo": "*",
                "ext-intl": "*",
-               "ext-mbstring": "*",
                "ext-wikidiff2": "*",
                "ext-apc": "*",
                "monolog/monolog": "*"

-- 
To view, visit https://gerrit.wikimedia.org/r/228778
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ade7498508d78706b8d1ccc902ce636951274bb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to