jenkins-bot has submitted this change and it was merged.
Change subject: Use DM serializer in SnakSerializationRendererTest
......................................................................
Use DM serializer in SnakSerializationRendererTest
Change-Id: Ia708232a14405d1dfd83beb0c9a49b11389ad770
---
M
client/tests/phpunit/includes/DataAccess/Scribunto/SnakSerializationRendererTest.php
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Bene: Looks good to me, approved
Jonas Kress (WMDE): Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git
a/client/tests/phpunit/includes/DataAccess/Scribunto/SnakSerializationRendererTest.php
b/client/tests/phpunit/includes/DataAccess/Scribunto/SnakSerializationRendererTest.php
index 3854bd3..624eacf 100644
---
a/client/tests/phpunit/includes/DataAccess/Scribunto/SnakSerializationRendererTest.php
+++
b/client/tests/phpunit/includes/DataAccess/Scribunto/SnakSerializationRendererTest.php
@@ -3,15 +3,17 @@
namespace Wikibase\Client\Tests\DataAccess\Scribunto;
use DataValues\DataValue;
+use DataValues\Serializers\DataValueSerializer;
use DataValues\StringValue;
use Language;
use PHPUnit_Framework_TestCase;
use Wikibase\Client\DataAccess\Scribunto\SnakSerializationRenderer;
+use Wikibase\Client\Usage\UsageAccumulator;
use Wikibase\Client\WikibaseClient;
use Wikibase\DataModel\Entity\EntityIdValue;
use Wikibase\DataModel\Entity\PropertyId;
+use Wikibase\DataModel\Serializers\SnakSerializer;
use Wikibase\DataModel\Snak\PropertyValueSnak;
-use Wikibase\Lib\Serializers\SnakSerializer;
/**
* @covers Wikibase\Client\DataAccess\Scribunto\SnakSerializationRenderer
@@ -36,8 +38,8 @@
$value
);
- $snakSerializer = new SnakSerializer();
- $serialized = $snakSerializer->getSerialized( $snak );
+ $snakSerializer = new SnakSerializer( new DataValueSerializer()
);
+ $serialized = $snakSerializer->serialize( $snak );
return $serialized;
}
--
To view, visit https://gerrit.wikimedia.org/r/227473
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia708232a14405d1dfd83beb0c9a49b11389ad770
Gerrit-PatchSet: 14
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Bene <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: JanZerebecki <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
