Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/229041
Change subject: Remove unused arguments.
......................................................................
Remove unused arguments.
Change-Id: I7aa10f71fb03915d1cf6732b3a38d7e33db55774
---
M repo/includes/ChangeOp/ChangeOpsMerge.php
M repo/includes/api/FormatSnakValue.php
M repo/includes/rdf/RdfBuilder.php
M repo/includes/rdf/TruthyStatementRdfBuilder.php
4 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/41/229041/1
diff --git a/repo/includes/ChangeOp/ChangeOpsMerge.php
b/repo/includes/ChangeOp/ChangeOpsMerge.php
index 1957692..cf49e00 100644
--- a/repo/includes/ChangeOp/ChangeOpsMerge.php
+++ b/repo/includes/ChangeOp/ChangeOpsMerge.php
@@ -190,7 +190,7 @@
private function generateAliasesChangeOps() {
foreach (
$this->fromItem->getFingerprint()->getAliasGroups()->toTextArray() as $langCode
=> $aliases ) {
$this->fromChangeOps->add(
$this->getFingerprintChangeOpFactory()->newRemoveAliasesOp( $langCode, $aliases
) );
- $this->toChangeOps->add(
$this->getFingerprintChangeOpFactory()->newAddAliasesOp( $langCode, $aliases,
'add' ) );
+ $this->toChangeOps->add(
$this->getFingerprintChangeOpFactory()->newAddAliasesOp( $langCode, $aliases )
);
}
}
diff --git a/repo/includes/api/FormatSnakValue.php
b/repo/includes/api/FormatSnakValue.php
index 419be58..51a2c81 100644
--- a/repo/includes/api/FormatSnakValue.php
+++ b/repo/includes/api/FormatSnakValue.php
@@ -84,7 +84,7 @@
$value = $this->decodeDataValue( $params['datavalue'] );
$dataTypeId = $this->getDataTypeId( $params );
- $formatter = $this->getFormatter( $value );
+ $formatter = $this->getFormatter();
if ( $formatter instanceof TypedValueFormatter ) {
// use data type id, if we can
diff --git a/repo/includes/rdf/RdfBuilder.php b/repo/includes/rdf/RdfBuilder.php
index c62414c..dd91f5b 100644
--- a/repo/includes/rdf/RdfBuilder.php
+++ b/repo/includes/rdf/RdfBuilder.php
@@ -151,7 +151,7 @@
*/
private function newTruthyStatementRdfBuilder() {
//NOTE: currently, the only simple values are supported in
truthy mode!
- $simpleValueBuilder = $this->newSimpleValueRdfBuilder(
$this->vocabulary, $this->propertyLookup );
+ $simpleValueBuilder = $this->newSimpleValueRdfBuilder();
$statementBuilder = new TruthyStatementRdfBuilder(
$this->vocabulary, $this->writer, $simpleValueBuilder );
return $statementBuilder;
@@ -444,7 +444,7 @@
* @param EntityDocument $entity
*/
private function addEntityStub( EntityDocument $entity ) {
- $this->addEntityMetaData( $entity, false );
+ $this->addEntityMetaData( $entity );
if ( $entity instanceof FingerprintProvider ) {
$fingerprint = $entity->getFingerprint();
diff --git a/repo/includes/rdf/TruthyStatementRdfBuilder.php
b/repo/includes/rdf/TruthyStatementRdfBuilder.php
index 51f0687..92e3f38 100644
--- a/repo/includes/rdf/TruthyStatementRdfBuilder.php
+++ b/repo/includes/rdf/TruthyStatementRdfBuilder.php
@@ -68,7 +68,7 @@
// FIXME: getBestStatementPerProperty() uis expensive, share
the result with FullStatementRdfBuilder!
foreach ( $statementList->getPropertyIds() as $propertyId ) {
foreach ( $statementList->getByPropertyId( $propertyId
)->getBestStatements() as $statement ) {
- $this->addMainSnak( $entityId, $statement, true
);
+ $this->addMainSnak( $entityId, $statement );
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/229041
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7aa10f71fb03915d1cf6732b3a38d7e33db55774
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
