AndyRussG has uploaded a new change for review.
https://gerrit.wikimedia.org/r/229164
Change subject: Campaign mixins: Fix handling of removed parameters
......................................................................
Campaign mixins: Fix handling of removed parameters
Change-Id: I6043c6ee5a54b81b6fb13240c6cc9ecf951f9066
---
M includes/Campaign.php
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/64/229164/1
diff --git a/includes/Campaign.php b/includes/Campaign.php
index 088dcef..70b2b88 100644
--- a/includes/Campaign.php
+++ b/includes/Campaign.php
@@ -650,6 +650,12 @@
$paramName = $dbRow->nmxnp_param_name;
$mixinDef =
$wgCentralNoticeCampaignMixins[$mixinName];
+
+ // Handle mixin parameters being removed, too
+ if ( !isset(
$mixinDef['parameters'][$paramName] ) ) {
+ continue;
+ }
+
$paramType =
$mixinDef['parameters'][$paramName]['type'];
switch ( $paramType ) {
--
To view, visit https://gerrit.wikimedia.org/r/229164
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6043c6ee5a54b81b6fb13240c6cc9ecf951f9066
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: campaign_mixins
Gerrit-Owner: AndyRussG <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
