jenkins-bot has submitted this change and it was merged.
Change subject: ve.ce.TableCellableNode: Only apply title to nodes which are
cellable
......................................................................
ve.ce.TableCellableNode: Only apply title to nodes which are cellable
Some classes mixin in cellable but don't always use it.
Change-Id: Ic997f4318a978cebc43782b534fdafd6367b670e
---
M src/ce/ve.ce.TableCellableNode.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ce/ve.ce.TableCellableNode.js
b/src/ce/ve.ce.TableCellableNode.js
index 930ba41..a31d214 100644
--- a/src/ce/ve.ce.TableCellableNode.js
+++ b/src/ce/ve.ce.TableCellableNode.js
@@ -13,7 +13,7 @@
* @constructor
*/
ve.ce.TableCellableNode = function VeCeTableCellableNode() {
- if ( !this.isCellEditable() ) {
+ if ( this.isCellable() && !this.isCellEditable() ) {
this.$element.attr( 'title', ve.msg(
'visualeditor-aliennode-tooltip' ) );
}
};
--
To view, visit https://gerrit.wikimedia.org/r/229165
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic997f4318a978cebc43782b534fdafd6367b670e
Gerrit-PatchSet: 2
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
