Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/229393
Change subject: Fix duplicate history entries when loading page from cache.
......................................................................
Fix duplicate history entries when loading page from cache.
When loading a page from cache, we were forgetting to update our
HistoryEntry to reflect the page's normalized title, as recorded in the
Page object.
Bug: T108031
Change-Id: I443b17e149f2d42c1219904a15330fe7a06f75e9
---
M app/src/main/java/org/wikipedia/page/JsonPageLoadStrategy.java
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/93/229393/1
diff --git a/app/src/main/java/org/wikipedia/page/JsonPageLoadStrategy.java
b/app/src/main/java/org/wikipedia/page/JsonPageLoadStrategy.java
index 2658380..ffe8f79 100644
--- a/app/src/main/java/org/wikipedia/page/JsonPageLoadStrategy.java
+++ b/app/src/main/java/org/wikipedia/page/JsonPageLoadStrategy.java
@@ -376,6 +376,10 @@
Log.d(TAG, "Using page from cache: " +
model.getTitleOriginal().getDisplayText());
model.setPage(page);
model.setTitle(page.getTitle());
+ // Update our history entry, in case the Title was
changed (i.e. normalized)
+ final HistoryEntry curEntry = model.getCurEntry();
+ model.setCurEntry(
+ new HistoryEntry(model.getTitle(),
curEntry.getSource()));
// load the current title's thumbnail from sqlite
updateThumbnail(PageImage.PERSISTENCE_HELPER.getImageUrlForTitle(app,
model.getTitle()));
// Save history entry...
--
To view, visit https://gerrit.wikimedia.org/r/229393
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I443b17e149f2d42c1219904a15330fe7a06f75e9
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
