jenkins-bot has submitted this change and it was merged.
Change subject: Correct description updated in the dialog
......................................................................
Correct description updated in the dialog
Changed 'console.log' to 'mw.log'
Added a block after if
Fixed code-style error
Change-Id: I4c0e394065b4772279edf6c1bd91a87f4bba5d05
---
M modules/ext.LanguageToolDialog.js
1 file changed, 21 insertions(+), 7 deletions(-)
Approvals:
Amire80: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.LanguageToolDialog.js
b/modules/ext.LanguageToolDialog.js
index 28eeffd..cc90ab8 100644
--- a/modules/ext.LanguageToolDialog.js
+++ b/modules/ext.LanguageToolDialog.js
@@ -46,6 +46,7 @@
* @inheritdoc
*/
mw.LanguageToolDialog.prototype.initialize = function () {
+ mw.log( 'intialize' );
// Parent method
mw.LanguageToolDialog.super.prototype.initialize.call( this );
@@ -164,6 +165,7 @@
* @inheritdoc
*/
mw.LanguageToolDialog.prototype.getSetupProcess = function ( data ) {
+ mw.log( 'getSetupProcess' );
data = data || {};
return mw.LanguageToolDialog.super.prototype.getSetupProcess.call(
this, data )
.first( function () {
@@ -192,6 +194,7 @@
* @inheritdoc
*/
mw.LanguageToolDialog.prototype.getReadyProcess = function ( data ) {
+ mw.log( 'getReadyProcess' );
return mw.LanguageToolDialog.super.prototype.getReadyProcess.call(
this, data )
.next( function () {
this.findText.focus().select();
@@ -202,6 +205,7 @@
* @inheritdoc
*/
mw.LanguageToolDialog.prototype.getTeardownProcess = function ( data ) {
+ mw.log( 'getTeardownProcess' );
return mw.LanguageToolDialog.super.prototype.getTeardownProcess.call(
this, data )
.next( function () {
var selection,
@@ -239,6 +243,7 @@
* Handle window scroll events
*/
mw.LanguageToolDialog.prototype.onWindowScroll = function () {
+ mw.log( 'onWindowScroll' );
if ( this.renderedFragments.getLength() < this.results ) {
// If viewport clipping is being used, reposition results based
on the current viewport
this.renderFragments();
@@ -249,6 +254,7 @@
* Handle change events to the find inputs (text or match case)
*/
mw.LanguageToolDialog.prototype.onFindChange = function () {
+ mw.log( 'onFindChange' );
this.updateFragments();
this.renderFragments();
this.highlightFocused( true );
@@ -260,6 +266,7 @@
* @param {jQuery.Event} e
*/
mw.LanguageToolDialog.prototype.onFindTextEnter = function ( e ) {
+ mw.log( 'onFindTextEnter' );
if ( !this.results ) {
return;
}
@@ -274,6 +281,7 @@
* Update search result fragments
*/
mw.LanguageToolDialog.prototype.updateFragments = function () {
+ mw.log( 'updateFragments' );
var i, l,
surfaceModel = this.surface.getModel(),
documentModel = surfaceModel.getDocument(),
@@ -302,6 +310,7 @@
* Position results markers
*/
mw.LanguageToolDialog.prototype.renderFragments = function () {
+ mw.log( 'renderFragments' );
if ( this.replacing ) {
return;
}
@@ -340,6 +349,7 @@
* @param {ve.Range} range Range of fragments to render
*/
mw.LanguageToolDialog.prototype.renderRangeOfFragments = function ( range ) {
+ mw.log( 'renderRangeOfFragments' );
var i, j, jlen, rects, $result, top;
this.$findResults.empty();
for ( i = range.start; i < range.end; i++ ) {
@@ -368,6 +378,7 @@
* @param {boolean} scrollIntoView Scroll the marker into view
*/
mw.LanguageToolDialog.prototype.highlightFocused = function ( scrollIntoView )
{
+ mw.log( 'highlightFocused' );
var $result, rect, top,
offset, windowScrollTop, windowScrollHeight,
surfaceView = this.surface.getView();
@@ -510,6 +521,9 @@
// TODO: Get the language from VE's data model
lang = mw.config.get( 'wgPageContentLanguage' );
+ if ( lang === 'en' ) {
+ lang = 'en-US';
+ }
$.ajax( {
type: 'POST',
@@ -517,7 +531,7 @@
url: 'http://tools.wmflabs.org/languageproofing/',
data: { language: lang, text: text }
} ).done( function ( responseXML ) {
- // console.log( responseXML );
+ // mw.log( responseXML );
self.openDialog.apply( self, [ responseXML, mapper ] );
} );
return;
@@ -644,12 +658,12 @@
*/
mw.LanguageToolDialog.prototype.highlightFragments = function () {
var i, j, rects, $result, top;
- window.console.log( 'Not using: ', top ); // FIXME
+ mw.log( 'Not using: ', top ); // FIXME
this.$errors.empty();
for ( i = 0; i < this.fragments.length; i++ ) {
rects = this.surface.getView().getSelectionRects(
this.fragments[ i ].getSelection() );
- // console.log( this.fragments[i].getSelection() );
+ // mw.log( this.fragments[i].getSelection() );
$result = $( '<div>' ).addClass(
've-ui-findAndReplaceDialog-findResult' );
for ( j = 0; j < rects.length; j++ ) {
$result.append( $( '<div>' ).css( {
@@ -669,15 +683,15 @@
surfaceModel = this.surface.getModel(),
selection = surfaceModel.getSelection(),
range = selection.getRange();
- window.console.log( range.start ); // FIXME
- window.console.log( range.end ); // FIXME
+ mw.log( range.start ); // FIXME
+ mw.log( range.end ); // FIXME
for ( i = 0; i < this.fragments.length; i++ ) {
if ( this.ranges[ i ].start <= range.start && range.end <=
this.ranges[ i ].end ) {
- window.console.log( surfaceModel.getLinearFragment(
this.ranges[ i ], true ) ); // FIXME
+ mw.log( surfaceModel.getLinearFragment( this.ranges[ i
], true ) ); // FIXME
suggestion = this.suggestions[ this.suggestionMapper[ i
] ].suggestions;
error = this.suggestions[ this.suggestionMapper[ i ]
].description;
- window.console.log( error ); // FIXME
+ mw.log( error ); // FIXME
this.findText.setValue( error );
this.replaceText.setValue( suggestion );
}
--
To view, visit https://gerrit.wikimedia.org/r/228278
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4c0e394065b4772279edf6c1bd91a87f4bba5d05
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Ankita-ks <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
