jenkins-bot has submitted this change and it was merged.
Change subject: Improve type resolving in SpecialViolationsPage
......................................................................
Improve type resolving in SpecialViolationsPage
Change-Id: I4f993bb43724d6bd261682b8770d2ba0c6a47ebd
---
M specials/SpecialViolationsPage.php
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/specials/SpecialViolationsPage.php
b/specials/SpecialViolationsPage.php
index 9141e5b..98da71d 100644
--- a/specials/SpecialViolationsPage.php
+++ b/specials/SpecialViolationsPage.php
@@ -14,6 +14,7 @@
use Wikibase\DataModel\Entity\PropertyId;
use Wikibase\DataModel\Services\EntityId\EntityIdParsingException;
use Wikibase\DataModel\Snak\PropertyValueSnak;
+use Wikibase\DataModel\Statement\StatementListProvider;
use Wikibase\Lib\EntityIdFormatter;
use Wikibase\Lib\OutputFormatValueFormatterFactory;
use Wikibase\Lib\SnakFormatter;
@@ -600,8 +601,8 @@
*/
private function formatClaimGuid( EntityId $entityId, $claimGuid ) {
$entity = $this->entityLookup->getEntity( $entityId );
- if ( $entity ) {
- foreach ( $entity->getStatements() as $statement ) {
+ if ( $entity instanceof StatementListProvider ) {
+ foreach ( $entity->getStatements()->toArray() as
$statement ) {
$mainSnak = $statement->getMainSnak();
if ( $statement->getGuid() !== $claimGuid || !(
$mainSnak instanceof PropertyValueSnak ) ) {
continue;
--
To view, visit https://gerrit.wikimedia.org/r/229636
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f993bb43724d6bd261682b8770d2ba0c6a47ebd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQuality
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
