Aaron Schulz has submitted this change and it was merged. Change subject: While testing, turn off DataBase::ignoreErrors. ......................................................................
While testing, turn off DataBase::ignoreErrors. Database errors should cause an exception, not return false, unless the test case, or the code under test, explicitely calls ignoreErrors(true). The DB object should be reset to fail fast and safe for every test. Change-Id: Ifc2a720ec46a1843d9ffb1488c54743a0099ef9d --- M tests/phpunit/MediaWikiTestCase.php 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Aaron Schulz: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37235 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc2a720ec46a1843d9ffb1488c54743a0099ef9d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Aaron Schulz <[email protected]> Gerrit-Reviewer: Hashar <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
