Alexandros Kosiaris has submitted this change and it was merged.
Change subject: service::node: Ensure saner permissions for logdir
......................................................................
service::node: Ensure saner permissions for logdir
There is no reason logdir to be owned by the group running the service
or having overly open permissions. Set the group to root and permissions
to 0755. logrotate complains about it otherwise. Note that not both are
required to make logrotate happy but it is a good precaution anyway.
Change-Id: If20d70ac17987eb832808eec84efc9f15ad5e02e
---
M modules/service/manifests/node.pp
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Mobrovac: Looks good to me, but someone else must approve
Alexandros Kosiaris: Verified; Looks good to me, approved
diff --git a/modules/service/manifests/node.pp
b/modules/service/manifests/node.pp
index 118560b..3a72189 100644
--- a/modules/service/manifests/node.pp
+++ b/modules/service/manifests/node.pp
@@ -126,8 +126,8 @@
file { $local_logdir:
ensure => directory,
owner => $title,
- group => $title,
- mode => '0775',
+ group => 'root',
+ mode => '0755',
before => Service[$title],
}
--
To view, visit https://gerrit.wikimedia.org/r/230071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If20d70ac17987eb832808eec84efc9f15ad5e02e
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Giuseppe Lavagetto <[email protected]>
Gerrit-Reviewer: Mobrovac <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
