Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230086
Change subject: Use platform's iOS detection, instead of collecting from
MobileFrontend
......................................................................
Use platform's iOS detection, instead of collecting from MobileFrontend
Change-Id: Ic206d54aee712e6309e34a0414d28c27363dfbc3
---
M modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/86/230086/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
index 3d1518a..b839d52 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
@@ -14,7 +14,6 @@
* @constructor
* @param {Object} [config] Configuration options
* @cfg {number} [section] Number of the section target should scroll to
- * @cfg {boolean} [isIos=false] Whether the platform is an iOS device
*/
ve.init.mw.MobileArticleTarget = function VeInitMwMobileArticleTarget( config
) {
var currentUri = new mw.Uri();
@@ -27,7 +26,6 @@
);
this.section = config.section;
- this.isIos = !!config.isIos;
// Initialization
this.$element.addClass( 've-init-mw-mobileArticleTarget' );
@@ -188,7 +186,7 @@
target = this;
setTimeout( function () {
- if ( target.isIos ) {
+ if ( ve.init.platform.constructor.static.isIos() ) {
position = headingNode.$element.offset().top -
target.toolbar.$element.height();
target.surface.$element.closest( '.overlay-content'
).scrollTop( position );
} else {
--
To view, visit https://gerrit.wikimedia.org/r/230086
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic206d54aee712e6309e34a0414d28c27363dfbc3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
