jenkins-bot has submitted this change and it was merged.
Change subject: WPB followup - move maxheight
......................................................................
WPB followup - move maxheight
Followup to Ifd696117d4614389685945ad3853a473179c2c03 to move max-height outside
media query as a general rule.
Bug: T108232
Change-Id: I385b11a55beea1c2a6922d5eb92b2da3268f3844
---
M resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
1 file changed, 4 insertions(+), 5 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git
a/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
index ed938c9..fac010a 100644
--- a/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
+++ b/resources/ext.WikidataPageBanner.styles/ext.WikidataPageBanner.less
@@ -18,6 +18,10 @@
max-width: 1800px;
height: auto;
margin: 1em 0;
+ overflow: hidden;
+ // rule for banners whose height may be much due to a different aspect
ratio other than
+ // Wikivoyage banners
+ max-height: 300px;
}
.wpb-topbanner .wpb-name {
@@ -67,11 +71,6 @@
// banner enlargement and faking banner cropping for small screens
@media screen and ( max-width: 400px ) {
.wpb-topbanner {
- overflow: hidden;
- // rule for banners whose height may be much due to a different
aspect ratio other than
- // Wikivoyage banners
- max-height: 300px;
-
.wpb-banner-image {
// this rule overrides the max-width:100% rule for
images in Skin Minerva so that banner
// can be increased in size for increasing the height
accordingly. The overflowing
--
To view, visit https://gerrit.wikimedia.org/r/230226
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I385b11a55beea1c2a6922d5eb92b2da3268f3844
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
