Florianschmidtwelzow has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230295
Change subject: Blacklist iOS8 for new Wikitext editor
......................................................................
Blacklist iOS8 for new Wikitext editor
Esanders pointed out, that a fixed bottom toolbar will not work for
iOS 8 devices. Blacklist iOS8 for now, so they use the "normal" plain
wikitext editor.
Change-Id: I29303e5a4ee9a6d887178dc75c32cf607b496bbc
---
M resources/mobile.editor/init.js
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/95/230295/1
diff --git a/resources/mobile.editor/init.js b/resources/mobile.editor/init.js
index 420bd12..91b749e 100644
--- a/resources/mobile.editor/init.js
+++ b/resources/mobile.editor/init.js
@@ -9,6 +9,7 @@
Button = M.require( 'Button' ),
Anchor = M.require( 'Anchor' ),
skin = M.require( 'skin' ),
+ browser = M.require( 'browser' );
disabledEditIcon = new Icon( {
name: 'edit'
} ),
@@ -146,7 +147,9 @@
*/
function loadSourceEditor() {
var rlModuleName, moduleName;
- if ( !user.inUserBucketA() &&
context.isBetaGroupMember() ) {
+ // use the new wikitexteditor with a basic
toolbar as a test for beta users and users
+ // without an iphone (bottom toolbars doesn't
work)
+ if ( !user.inUserBucketA() &&
context.isBetaGroupMember() && !browser.isIos( 8 ) ) {
moduleName =
'modules/editor/EditorOverlayWithToolbar';
rlModuleName =
'mobile.editor.overlay.withtoolbar';
} else {
--
To view, visit https://gerrit.wikimedia.org/r/230295
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I29303e5a4ee9a6d887178dc75c32cf607b496bbc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Florianschmidtwelzow <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
