Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230300
Change subject: Mobile fixes
......................................................................
Mobile fixes
* Move MF overlay z-index hack out to MF
* Add webkit touch scrolling to panels
* Use named classes for hiding toolbars
* Centre tools
Depends on Ia46e6b4d7a in MF
Change-Id: I0e1f527446fd10fde5dd3107e6467fd2c8f621b2
---
M modules/ve-mw/init/styles/ve.init.mw.MobileArticleTarget.css
M modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
2 files changed, 46 insertions(+), 23 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/00/230300/1
diff --git a/modules/ve-mw/init/styles/ve.init.mw.MobileArticleTarget.css
b/modules/ve-mw/init/styles/ve.init.mw.MobileArticleTarget.css
index af57c29..c5607ac 100644
--- a/modules/ve-mw/init/styles/ve.init.mw.MobileArticleTarget.css
+++ b/modules/ve-mw/init/styles/ve.init.mw.MobileArticleTarget.css
@@ -5,9 +5,8 @@
* @license The MIT License (MIT); see LICENSE.txt
*/
-.ve-ui-overlay {
- /* enough to cover .overlay-header-container with z-index: 5 */
- z-index: 6;
+.oo-ui-panelLayout-scrollable {
+ -webkit-overflow-scrolling: touch;
}
.ve-init-mw-target-surface .ve-ce-documentNode,
@@ -40,7 +39,7 @@
display: none;
}
-.ve-init-mw-mobileArticleTarget-toolbar .oo-ui-toolbar-actions {
+.ve-init-mw-mobileArticleTarget-actions {
float: none;
display: table;
}
@@ -70,28 +69,47 @@
right: 0;
}
-.ve-init-mw-mobileArticleTarget-toolbar .oo-ui-toolbar-tools {
+.ve-init-mw-mobileArticleTarget-tools {
display: table;
width: 100%;
}
-.ve-init-mw-mobileArticleTarget-toolbar .oo-ui-toolbar-tools >
.oo-ui-toolGroup {
+.ve-init-mw-mobileArticleTarget-tools > .oo-ui-toolGroup {
display: table-cell;
+ text-align: center;
}
-.ve-init-mw-mobileArticleTarget-toolbar .oo-ui-toolbar-tools >
.oo-ui-toolGroup-empty {
+.ve-init-mw-mobileArticleTarget-tools .oo-ui-popupToolGroup-handle
.oo-ui-iconElement-icon {
+ left: 50%;
+ margin-left: -1.875em;
+}
+
+.ve-init-mw-mobileArticleTarget-tools .oo-ui-popupToolGroup-handle
.oo-ui-indicatorElement-indicator {
+ left: 50%;
+}
+
+.ve-init-mw-mobileArticleTarget-tools .oo-ui-popupToolGroup
.oo-ui-toolGroup-tools {
+ text-align: left;
+}
+
+.ve-init-mw-mobileArticleTarget-tools > .oo-ui-toolGroup-empty {
display: none;
}
-.ve-init-mw-mobileArticleTarget-toolbar .oo-ui-toolbar-tools >
.oo-ui-toolGroup:last-child {
+.ve-init-mw-mobileArticleTarget-tools > .oo-ui-toolGroup:last-child {
border-right: 0;
}
-.ve-init-mw-mobileArticleTarget-toolbar .oo-ui-toolbar-tools >
.oo-ui-toolGroup > .oo-ui-toolGroup-tools
+.ve-init-mw-mobileArticleTarget-tools > .oo-ui-toolGroup >
.oo-ui-toolGroup-tools
> .oo-ui-tool {
width: 100%;
}
+.ve-init-mw-mobileArticleTarget-tools-hidden,
+.ve-init-mw-mobileArticleTarget-actions-hidden {
+ display: none;
+}
+
@media (max-width: 479px) {
.ve-init-mw-mobileArticleTarget-toolbar
.oo-ui-barToolGroup > .oo-ui-toolGroup-tools >
.oo-ui-tool.oo-ui-iconElement.oo-ui-tool-with-label > .oo-ui-tool-link
.oo-ui-tool-title {
diff --git a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
index dcc510f..61eb087 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
@@ -90,11 +90,11 @@
ve.init.mw.MobileArticleTarget.prototype.onSurfaceSelect = function () {
var toolbar = this.getToolbar();
if ( this.getSurface().getModel().getSelection().isNull() ) {
- toolbar.$group.addClass( 'oo-ui-element-hidden' );
- toolbar.$actions.removeClass( 'oo-ui-element-hidden' );
+ toolbar.$group.addClass(
've-init-mw-mobileArticleTarget-tools-hidden' );
+ toolbar.$actions.removeClass(
've-init-mw-mobileArticleTarget-actions-hidden' );
} else {
- toolbar.$group.removeClass( 'oo-ui-element-hidden' );
- toolbar.$actions.addClass( 'oo-ui-element-hidden' );
+ toolbar.$group.removeClass(
've-init-mw-mobileArticleTarget-tools-hidden' );
+ toolbar.$actions.addClass(
've-init-mw-mobileArticleTarget-actions-hidden' );
}
};
@@ -124,7 +124,7 @@
this.toolbar.$element.addClass(
've-init-mw-mobileArticleTarget-toolbar' );
// Append the context to the toolbar
- this.toolbar.$bar.append( surface.context.$element );
+ this.toolbar.$bar.append( surface.getContext().$element );
};
/**
@@ -152,15 +152,20 @@
this.actionsToolbar.emit( 'updateState' );
- this.toolbar.$actions.append(
- this.actionsToolbar.$element,
- $( '<div>' ).addClass(
've-init-mw-mobileArticleTarget-title-container' ).append(
- $( '<div>' ).addClass(
've-init-mw-mobileArticleTarget-title' ).text(
- new mw.Title( ve.init.target.pageName
).getMainText()
- )
- ),
- this.toolbarSaveButton.$element
- );
+ this.toolbar.$group
+ .addClass( 've-init-mw-mobileArticleTarget-tools' );
+
+ this.toolbar.$actions
+ .addClass( 've-init-mw-mobileArticleTarget-actions' )
+ .append(
+ this.actionsToolbar.$element,
+ $( '<div>' ).addClass(
've-init-mw-mobileArticleTarget-title-container' ).append(
+ $( '<div>' ).addClass(
've-init-mw-mobileArticleTarget-title' ).text(
+ new mw.Title( ve.init.target.pageName
).getMainText()
+ )
+ ),
+ this.toolbarSaveButton.$element
+ );
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/230300
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0e1f527446fd10fde5dd3107e6467fd2c8f621b2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
