jenkins-bot has submitted this change and it was merged.
Change subject: TextInputWidget: Update doc'ed requirements for validate
function
......................................................................
TextInputWidget: Update doc'ed requirements for validate function
While getValidity supports promises that resolves with 'false' its a
better pattern if these promises were rejected.
Change-Id: I6b38b86cdeced6b04a143163d713f55568a815db
---
M src/widgets/TextInputWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/widgets/TextInputWidget.js b/src/widgets/TextInputWidget.js
index d0fcb9e..92764ee 100644
--- a/src/widgets/TextInputWidget.js
+++ b/src/widgets/TextInputWidget.js
@@ -53,7 +53,7 @@
* pattern defined by the class: 'non-empty' (the value cannot be an empty
string) or 'integer'
* (the value must contain only numbers); when RegExp, a regular expression
that must match the
* value for it to be considered valid; when Function, a function receiving
the value as parameter
- * that must return true, or promise resolving to true, for it to be
considered valid.
+ * that must return true, or promise that resolves, for it to be considered
valid.
*/
OO.ui.TextInputWidget = function OoUiTextInputWidget( config ) {
// Configuration initialization
--
To view, visit https://gerrit.wikimedia.org/r/230272
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b38b86cdeced6b04a143163d713f55568a815db
Gerrit-PatchSet: 3
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
