jenkins-bot has submitted this change and it was merged.
Change subject: Fix the display of the libraries in Special:Version for RTL
wikis
......................................................................
Fix the display of the libraries in Special:Version for RTL wikis
Bug: T108325
Change-Id: I3c9a675fa7330d46090a64c003bcaf66ddf4260f
---
M includes/specials/SpecialVersion.php
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
Eranroz: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/specials/SpecialVersion.php
b/includes/specials/SpecialVersion.php
index 4fb6772..e598f0b 100644
--- a/includes/specials/SpecialVersion.php
+++ b/includes/specials/SpecialVersion.php
@@ -541,6 +541,10 @@
return $arr['name'];
}, $info['authors'] );
$authors = $this->listAuthors( $authors, false,
"$IP/vendor/$name" );
+
+ // We can safely assume that the libraries' names and
descriptions
+ // are written in English and aren't going to be
translated,
+ // so set appropriate lang and dir attributes
$out .= Html::openElement( 'tr' )
. Html::rawElement(
'td',
@@ -551,9 +555,9 @@
array( 'class' =>
'mw-version-library-name' )
)
)
- . Html::element( 'td', array(),
$info['version'] )
- . Html::element( 'td', array(),
$this->listToText( $info['licenses'] ) )
- . Html::element( 'td', array(),
$info['description'] )
+ . Html::element( 'td', array( 'dir' => 'auto'
), $info['version'] )
+ . Html::element( 'td', array( 'dir' => 'auto'
), $this->listToText( $info['licenses'] ) )
+ . Html::element( 'td', array( 'lang' => 'en',
'dir' => 'ltr' ), $info['description'] )
. Html::rawElement( 'td', array(), $authors )
. Html::closeElement( 'tr' );
}
--
To view, visit https://gerrit.wikimedia.org/r/230105
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3c9a675fa7330d46090a64c003bcaf66ddf4260f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Amire80 <[email protected]>
Gerrit-Reviewer: Eranroz <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
