Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230528
Change subject: [PULL THROUGH] Target handles toolbar floating
......................................................................
[PULL THROUGH] Target handles toolbar floating
Depends on Icc47a0dc in core.
Change-Id: I0751817e3a6668b120134bfcb6c611b121a46501
---
M modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
M modules/ve-mw/init/ve.init.mw.Target.js
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/28/230528/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
index 74b1b97..bc2596e 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.MobileArticleTarget.js
@@ -141,6 +141,7 @@
ve.init.mw.MobileArticleTarget.prototype.attachToolbar = function () {
// Move the toolbar to the overlay header
this.toolbar.$element.appendTo( '.overlay-header > .toolbar' );
+ this.toolbar.initialize();
};
/**
diff --git a/modules/ve-mw/init/ve.init.mw.Target.js
b/modules/ve-mw/init/ve.init.mw.Target.js
index 33d2516..13ada45 100644
--- a/modules/ve-mw/init/ve.init.mw.Target.js
+++ b/modules/ve-mw/init/ve.init.mw.Target.js
@@ -24,8 +24,7 @@
config.toolbarConfig = $.extend( {
shadow: true,
actions: true,
- floatable: true,
- scrollOffset: mw.config.get(
'wgVisualEditorToolbarScrollOffset', 0 )
+ floatable: true
}, config.toolbarConfig );
// Parent constructor
@@ -39,6 +38,7 @@
this.toolbarSaveButton = null;
this.pageName = pageName;
this.pageExists = mw.config.get( 'wgArticleId', 0 ) !== 0;
+ this.toolbarScrollOffset = mw.config.get(
'wgVisualEditorToolbarScrollOffset', 0 );
// Sometimes we actually don't want to send a useful oldid
// if we do, PostEdit will give us a 'page restored' message
--
To view, visit https://gerrit.wikimedia.org/r/230528
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0751817e3a6668b120134bfcb6c611b121a46501
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
