Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230565
Change subject: Use es5-shim (and sham) for IE 8 compatibility
......................................................................
Use es5-shim (and sham) for IE 8 compatibility
The demo is supposed to work with this, but it currently doesn't.
Change-Id: Id90a8fa597eb60ac65b08f9ee018654a3042fe64
---
M Gruntfile.js
M demos/index.html
M demos/widgets.php
M jsduck.eg-iframe.html
M package.json
M tests/index.php
6 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/65/230565/1
diff --git a/Gruntfile.js b/Gruntfile.js
index fb13fd0..ae29d7f 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -245,7 +245,7 @@
},
demos: {
// Make sure you update this if dependencies
are added
- src:
'{node_modules/{jquery,oojs}/dist/**/*,composer.json,dist/**/*,php/**/*}',
+ src:
'{node_modules/{jquery,oojs}/dist/**/*,node_modules/es5-shim/*.js,composer.json,dist/**/*,php/**/*}',
dest: 'demos/',
expand: true
},
diff --git a/demos/index.html b/demos/index.html
index 93c8a86..2d73175 100644
--- a/demos/index.html
+++ b/demos/index.html
@@ -8,6 +8,8 @@
</head>
<body>
<script src="node_modules/jquery/dist/jquery.js"></script>
+ <script src="node_modules/es5-shim/es5-shim.js"></script>
+ <script src="node_modules/es5-shim/es5-sham.js"></script>
<script src="node_modules/oojs/dist/oojs.jquery.js"></script>
<script src="dist/oojs-ui.js"></script>
<script src="dist/oojs-ui-apex.js"></script>
diff --git a/demos/widgets.php b/demos/widgets.php
index 11f5def..e253ee9 100644
--- a/demos/widgets.php
+++ b/demos/widgets.php
@@ -980,6 +980,8 @@
<!-- Demonstrate JavaScript "infusion" of PHP widgets -->
<script src="node_modules/jquery/dist/jquery.js"></script>
+ <script src="node_modules/es5-shim/es5-shim.js"></script>
+ <script src="node_modules/es5-shim/es5-sham.js"></script>
<script src="node_modules/oojs/dist/oojs.jquery.js"></script>
<script src="dist/oojs-ui.js"></script>
<script src="dist/oojs-ui-<?php echo $theme; ?>.js"></script>
diff --git a/jsduck.eg-iframe.html b/jsduck.eg-iframe.html
index bd9c9dd..8eaabd9 100644
--- a/jsduck.eg-iframe.html
+++ b/jsduck.eg-iframe.html
@@ -15,6 +15,8 @@
</head>
<body>
<script src="node_modules/jquery/dist/jquery.js"></script>
+ <script src="node_modules/es5-shim/es5-shim.js"></script>
+ <script src="node_modules/es5-shim/es5-sham.js"></script>
<script src="node_modules/oojs/dist/oojs.jquery.js"></script>
<script src="dist/oojs-ui.js"></script>
<script src="dist/oojs-ui-apex.js"></script>
diff --git a/package.json b/package.json
index 8f4177a..5dd5879 100644
--- a/package.json
+++ b/package.json
@@ -21,6 +21,7 @@
"demos": "grunt demos"
},
"dependencies": {
+ "es5-shim": "4.1.10",
"jquery": "1.11.3",
"oojs": "1.1.8"
},
diff --git a/tests/index.php b/tests/index.php
index 98bb464..14c526b 100644
--- a/tests/index.php
+++ b/tests/index.php
@@ -27,6 +27,8 @@
</script>
<!-- Dependencies -->
<script src="../node_modules/jquery/dist/jquery.js"></script>
+ <script src="../node_modules/es5-shim/es5-shim.js"></script>
+ <script src="../node_modules/es5-shim/es5-sham.js"></script>
<script src="../node_modules/oojs/dist/oojs.jquery.js"></script>
<!-- Source code -->
<script src="../dist/oojs-ui.js"></script>
--
To view, visit https://gerrit.wikimedia.org/r/230565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id90a8fa597eb60ac65b08f9ee018654a3042fe64
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
