Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230592
Change subject: [WIP] Delete button for node context items
......................................................................
[WIP] Delete button for node context items
Bug: T62110
Change-Id: I41109537d2732f85622991871ee1bf4063808cbd
---
M src/ui/ve.ui.ContextItem.js
1 file changed, 22 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/VisualEditor/VisualEditor
refs/changes/92/230592/1
diff --git a/src/ui/ve.ui.ContextItem.js b/src/ui/ve.ui.ContextItem.js
index cfd5caa..c1d72f6 100644
--- a/src/ui/ve.ui.ContextItem.js
+++ b/src/ui/ve.ui.ContextItem.js
@@ -45,10 +45,23 @@
classes: [ 've-ui-contextItem-editButton' ]
}
) );
+ this.deleteButton = new OO.ui.ButtonWidget( ve.extendObject(
+ this.context.getButtonConfig(),
+ {
+ icon: 'remove',
+ flags: [ 'destructive' ]
+ }
+ ) );
+ this.actionButtons = new OO.ui.ButtonGroupWidget( {
+ items: [ this.editButton ]
+ } );
+ this.actionButtons.addItems( [ this.deleteButton ], 0 );
this.fragment = null;
+ this.isNode = model && model instanceof ve.dm.Node;
// Events
this.editButton.connect( this, { click: 'onEditButtonClick' } );
+ this.deleteButton.connect( this, { click: 'onDeleteButtonClick' } );
this.$element.on( 'mousedown', false );
// Initialization
@@ -63,7 +76,7 @@
.append( this.$icon, this.$label );
this.$actions
.addClass( 've-ui-contextItem-actions' )
- .append( this.editButton.$element );
+ .append( this.actionButtons.$element );
this.$head
.addClass( 've-ui-contextItem-head' )
.append( this.$title, this.$info, this.$actions );
@@ -142,6 +155,13 @@
};
/**
+ * Handle delete button click events.
+ */
+ve.ui.ContextItem.prototype.onDeleteButtonClick = function () {
+ this.getFragment().removeContent();
+};
+
+/**
* Check if this item is compatible with a given model.
*
* @static
@@ -179,7 +199,7 @@
ve.ui.ContextItem.prototype.getFragment = function () {
if ( !this.fragment ) {
var surfaceModel = this.context.getSurface().getModel();
- this.fragment = this.model && this.model instanceof ve.dm.Node ?
+ this.fragment = this.isNode ?
surfaceModel.getLinearFragment(
this.model.getOuterRange() ) :
surfaceModel.getFragment();
}
--
To view, visit https://gerrit.wikimedia.org/r/230592
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I41109537d2732f85622991871ee1bf4063808cbd
Gerrit-PatchSet: 1
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
