Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230594
Change subject: Add no link to Special:RecentChanges when tag filter is disabeld
......................................................................
Add no link to Special:RecentChanges when tag filter is disabeld
When wgUseTagFilter = false there is no need to link to
Special:RecentChanges because the special page cannot display the tag
filter and will show all changes, which is wrong.
Bug: T105650
Change-Id: I389aba9cb2862df3ba6980333c5cc94bb30dc202
---
M includes/specials/SpecialTags.php
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/94/230594/1
diff --git a/includes/specials/SpecialTags.php
b/includes/specials/SpecialTags.php
index a6847e1..70eee9f 100644
--- a/includes/specials/SpecialTags.php
+++ b/includes/specials/SpecialTags.php
@@ -216,15 +216,17 @@
$newRow .= Xml::tags( 'td', null, $this->msg( $activeMsg
)->escaped() );
$hitcountLabel = $this->msg( 'tags-hitcount' )->numParams(
$hitcount )->escaped();
- $hitcountLink = Linker::link(
- SpecialPage::getTitleFor( 'Recentchanges' ),
- $hitcountLabel,
- array(),
- array( 'tagfilter' => $tag )
- );
+ if ( $this->getConfig()->get( 'UseTagFilter' ) ) {
+ $hitcountLabel = Linker::link(
+ SpecialPage::getTitleFor( 'Recentchanges' ),
+ $hitcountLabel,
+ array(),
+ array( 'tagfilter' => $tag )
+ );
+ }
// add raw $hitcount for sorting, because tags-hitcount
contains numbers and letters
- $newRow .= Xml::tags( 'td', array( 'data-sort-value' =>
$hitcount ), $hitcountLink );
+ $newRow .= Xml::tags( 'td', array( 'data-sort-value' =>
$hitcount ), $hitcountLabel );
// actions
if ( $showActions ) { // we've already checked that the user
had the requisite userright
--
To view, visit https://gerrit.wikimedia.org/r/230594
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I389aba9cb2862df3ba6980333c5cc94bb30dc202
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
