[MediaWiki-commits] [Gerrit] Replace works with bugs - change (mediawiki...LanguageTool)

[Ankita-ks (Code Review)]

Ankita-ks has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/230732

Change subject: Replace works with bugs
......................................................................

Replace works with bugs

Replaces the first error correctly but removes the highlight from the
second error too.

Change-Id: I790dd08a0f81381bda314e54bf5e8b250042fa91
---
M modules/ext.LanguageToolDialog.js
1 file changed, 17 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/LanguageTool 
refs/changes/32/230732/1

diff --git a/modules/ext.LanguageToolDialog.js 
b/modules/ext.LanguageToolDialog.js
index 2b49002..cda61b9 100644
--- a/modules/ext.LanguageToolDialog.js
+++ b/modules/ext.LanguageToolDialog.js
@@ -54,7 +54,7 @@
        // Properties
        this.surface = null;
        this.errors = [];
-       this.ranges = [];
+       //this.ranges = [];
        this.$errors = $( '<div>' ).addClass( 
've-ui-findAndReplaceDialog-findResults' );
        this.initialFragment = null;
        this.fragments = [];
@@ -238,23 +238,30 @@
  * Update search result fragments
  */
 mw.LanguageToolDialog.prototype.updateFragments = function () {
+       console.log( 'updateFragments' );
        var i, l,
                surfaceModel = this.surface.getModel(),
                documentModel = surfaceModel.getDocument(),
                ranges = [],
                find = this.findText.getValue();
 
-       this.send();
-       this.query = find;
+       //this.send();
+       //this.query = find;
        this.findText.setValidityFlag();
 
+       /*this.$errors.empty().detach();
+       this.fragments = [];
+       this.send();*/
+       this.fragments.splice( this.focusedIndex, 1 );
+       this.errors.splice( this.focusedIndex, 1 );
+       /*
        this.fragments = [];
        if ( this.query ) {
-               ranges = documentModel.findText( this.query, /*matchCase,*/ 
true );
-               for ( i = 0, l = ranges.length; i < l; i++ ) {
-                       this.fragments.push( surfaceModel.getLinearFragment( 
ranges[ i ], true, true ) );
-               }
-       }
+               ranges = documentModel.findText( this.query, /*matchCase,*/ 
//true );
+       //      for ( i = 0, l = ranges.length; i < l; i++ ) {
+                       //this.fragments.push( surfaceModel.getLinearFragment( 
ranges[ i ], true, true ) );
+       //      }
+       //}
        this.results = this.fragments.length;
        this.focusedIndex = Math.min( this.focusedIndex, this.results ? 
this.results - 1 : 0 );
        this.nextButton.setDisabled( !this.results );
@@ -489,7 +496,7 @@
                errorIndex, error, spanStart, spanEnd,
                range, fragment, ruleId, surfaceModel;
 
-       this.ranges = [];
+       //this.ranges = [];
        this.fragments = [];
 
        this.processXML( responseXML );
@@ -517,7 +524,7 @@
                        fragment = surfaceModel.getLinearFragment( range, true, 
true );
 
                        ruleId = error.ruleId;
-                       this.ranges.push( range );
+                       //this.ranges.push( range );
                        this.fragments.push( fragment );
 
                        if ( ruleId.indexOf( 'SPELLER_RULE' ) >= 0 ||

-- 
To view, visit https://gerrit.wikimedia.org/r/230732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I790dd08a0f81381bda314e54bf5e8b250042fa91
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LanguageTool
Gerrit-Branch: master
Gerrit-Owner: Ankita-ks <kumariankita...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits