jenkins-bot has submitted this change and it was merged. Change subject: (bug 37837) Spinner of death on error ......................................................................
(bug 37837) Spinner of death on error * Reusing deactivate method to recover from load error * Made deactivate resilient to some properties not being set yet (so we can call it on load error) * Restoring save dialog state after save error Change-Id: I6a697dc6bddeebecf4e2ab26805bee9f3754c714 --- M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js 1 file changed, 13 insertions(+), 10 deletions(-) Approvals: Robmoen: Looks good to me, approved jenkins-bot: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/37320 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a697dc6bddeebecf4e2ab26805bee9f3754c714 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Trevor Parscal <[email protected]> Gerrit-Reviewer: Robmoen <[email protected]> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
