Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230947
Change subject: Measure how long it takes for the flyout to open
......................................................................
Measure how long it takes for the flyout to open
Bug: T56486
Change-Id: I12bfbfb186e8ab2bfe22052402ad4c71b2e6bd81
---
M modules/overlay/ext.echo.overlay.init.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/47/230947/1
diff --git a/modules/overlay/ext.echo.overlay.init.js
b/modules/overlay/ext.echo.overlay.init.js
index abb775e..a701e18 100644
--- a/modules/overlay/ext.echo.overlay.init.js
+++ b/modules/overlay/ext.echo.overlay.init.js
@@ -6,7 +6,7 @@
}
$link.click( function ( e ) {
- var $target;
+ var $target, time = Date.now();
// log the badge click
mw.echo.logInteraction( 'ui-badge-link-click' );
@@ -41,6 +41,8 @@
// Show the notifications overlay
$overlay.show();
+ mw.track(
'timing.MediaWiki.echo.overlay', Date.now() - time );
+
// Make sure the overlay is visible,
even if the badge is near the edge of browser window.
// 10 is an arbitrarily chosen "close
enough" number.
// We are careful not to slide out from
below the pokey (which is 21px wide) (200-21/2+1 == 189)
--
To view, visit https://gerrit.wikimedia.org/r/230947
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I12bfbfb186e8ab2bfe22052402ad4c71b2e6bd81
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
