Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/230952
Change subject: Hygiene: Enforce dot notation
......................................................................
Hygiene: Enforce dot notation
Change-Id: I5c613b110aa847a2f9f37c9052d715bbd632ce76
---
M .jscsrc
M resources/mobile.gallery/PhotoListApi.js
M resources/mobile.infobox/Infobox.js
M resources/mobile.special.notifications.scripts/notifications.js
M resources/mobile.watchlist/WatchListApi.js
5 files changed, 4 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/52/230952/1
diff --git a/.jscsrc b/.jscsrc
index 33503b8..9a9d529 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -1,7 +1,6 @@
{
"preset": "wikimedia",
- "requireDotNotation": null,
"requireVarDeclFirst": null,
"requireSpacesInsideBrackets": null,
"disallowDanglingUnderscores": null,
diff --git a/resources/mobile.gallery/PhotoListApi.js
b/resources/mobile.gallery/PhotoListApi.js
index 8936acf..512f869 100644
--- a/resources/mobile.gallery/PhotoListApi.js
+++ b/resources/mobile.gallery/PhotoListApi.js
@@ -123,7 +123,7 @@
} );
if ( resp.hasOwnProperty(
'continue' ) ) {
- self.continueParams =
resp['continue'];
+ self.continueParams =
resp.continue;
} else {
self.canContinue =
false;
}
diff --git a/resources/mobile.infobox/Infobox.js
b/resources/mobile.infobox/Infobox.js
index 92063e9..0893acd 100644
--- a/resources/mobile.infobox/Infobox.js
+++ b/resources/mobile.infobox/Infobox.js
@@ -307,7 +307,7 @@
getDefaultsFromClaims: function ( claims ) {
var defaults,
self = this,
- fallback = this.typeDefaults['default'] ||
+ fallback = this.typeDefaults.default ||
{
rows: []
};
diff --git a/resources/mobile.special.notifications.scripts/notifications.js
b/resources/mobile.special.notifications.scripts/notifications.js
index 50e8289..50bfdfc 100644
--- a/resources/mobile.special.notifications.scripts/notifications.js
+++ b/resources/mobile.special.notifications.scripts/notifications.js
@@ -79,7 +79,7 @@
} );
} );
- notContinue = notifications['continue'];
+ notContinue = notifications.continue;
if ( unread.length > 0 ) {
markAsRead( unread );
} else {
diff --git a/resources/mobile.watchlist/WatchListApi.js
b/resources/mobile.watchlist/WatchListApi.js
index 283cdbb..a61f323 100644
--- a/resources/mobile.watchlist/WatchListApi.js
+++ b/resources/mobile.watchlist/WatchListApi.js
@@ -69,7 +69,7 @@
url: this.apiUrl
} ).then( function ( data ) {
if ( data.hasOwnProperty( 'continue' ) ) {
- self.continueParams = data['continue'];
+ self.continueParams = data.continue;
} else {
self.canContinue = false;
}
--
To view, visit https://gerrit.wikimedia.org/r/230952
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c613b110aa847a2f9f37c9052d715bbd632ce76
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
