Sumit has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/230975

Change subject: WikidataPageBanner add class "image" to a:link
......................................................................

WikidataPageBanner add class "image" to a:link

Since MultimediaViewer operates on links with class image, add the class <a> tag
around banner so that MultimediaViewer recognizes the banner.

Bug: T108778
Change-Id: Iaa9fe57fb96104e6ba222d54c2aa08916870d906
---
M templates/banner.mustache
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikidataPageBanner 
refs/changes/75/230975/1

diff --git a/templates/banner.mustache b/templates/banner.mustache
index e6e9c62..089cbd4 100644
--- a/templates/banner.mustache
+++ b/templates/banner.mustache
@@ -1,7 +1,7 @@
 <div class="ext-wpb-pagebanner noprint">
        <div class="wpb-topbanner">
                <div class="wpb-name">{{title}}</div>
-               <a title="{{tooltip}}" href="{{bannerfile}}"><img 
src="{{banner}}" srcset="{{srcset}}" class="wpb-banner-image {{originx}}" 
data-pos-x="{{data-pos-x}}" data-pos-y="{{data-pos-y}}"></a>
+               <a class="image" title="{{tooltip}}" href="{{bannerfile}}"><img 
src="{{banner}}" srcset="{{srcset}}" class="wpb-banner-image {{originx}}" 
data-pos-x="{{data-pos-x}}" data-pos-y="{{data-pos-y}}"></a>
                {{#hasIcons}}
                <div class="wpb-iconbox">
                        {{#icons}}

-- 
To view, visit https://gerrit.wikimedia.org/r/230975
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaa9fe57fb96104e6ba222d54c2aa08916870d906
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <asthana.sumi...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to