Robert Vogel has submitted this change and it was merged.
Change subject: Fixed hook handler signatures
......................................................................
Fixed hook handler signatures
The signatures of the hookhandler methods did not match the hook calls. In
some cases this broke the functionality of the extension.
Change-Id: I77d68aacbfc2e3bd01dd769dd11e1bb9bc156f95
---
M NSFileRepo.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Robert Vogel: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/NSFileRepo.php b/NSFileRepo.php
index 8b8da9c..a771daa 100644
--- a/NSFileRepo.php
+++ b/NSFileRepo.php
@@ -78,7 +78,7 @@
/**
* Check for Namespace in Title Line
*/
-function NSFileRepoNSCheck( $uploadForm ) {
+function NSFileRepoNSCheck( &$uploadForm ) {
$title = Title::newFromText($uploadForm->mDesiredDestName);
if( $title === null ) {
return true;
@@ -96,7 +96,7 @@
/**
* If Extension:Lockdown has been activated (recommend), check individual
namespace protection
*/
-function NSFileRepolockdownUserCan( $title, $user, $action, &$result) {
+function NSFileRepolockdownUserCan( &$title, &$user, $action, &$result) {
global $wgWhitelistRead;
if ( $wgWhitelistRead !== false && in_array( $title->getPrefixedText(),
$wgWhitelistRead ) ) {
return true;
@@ -112,7 +112,7 @@
return true;
}
-function NSFileRepoImgAuthCheck( $title, $path, $name, $result ) {
+function NSFileRepoImgAuthCheck( &$title, &$path, &$name, &$result ) {
global $wgContLang;
# See if stored in a NS path
--
To view, visit https://gerrit.wikimedia.org/r/227700
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77d68aacbfc2e3bd01dd769dd11e1bb9bc156f95
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/NSFileRepo
Gerrit-Branch: master
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
