jenkins-bot has submitted this change and it was merged.
Change subject: Revert "mediawiki.page.ready: When infusing, infuse by id, not
by element"
......................................................................
Revert "mediawiki.page.ready: When infusing, infuse by id, not by element"
Infusing by element is better, since it avoids the
document.getElementById() lookup and behaves better in case
of duplicate ids (which is invalid HTML, but happens).
This reverts commit 803d89173fc3a56871767663907785cb3eaf7aa5.
Depends on I11fd1c7f2434f904b9ddc94b0903f8278e06f3a1 in OOjs UI.
Bug: T105828
Change-Id: I8c1f5015229db7b8a391f324cfd96be4ac158041
---
M resources/src/mediawiki.page/mediawiki.page.ready.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.page/mediawiki.page.ready.js
b/resources/src/mediawiki.page/mediawiki.page.ready.js
index 70029a1..8ec4cf0 100644
--- a/resources/src/mediawiki.page/mediawiki.page.ready.js
+++ b/resources/src/mediawiki.page/mediawiki.page.ready.js
@@ -64,7 +64,7 @@
if ( $nodes.length ) {
mw.loader.using( 'mediawiki.widgets' ).done( function
() {
$nodes.each( function () {
- OO.ui.infuse( this.id );
+ OO.ui.infuse( this );
} );
} );
}
--
To view, visit https://gerrit.wikimedia.org/r/229671
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c1f5015229db7b8a391f324cfd96be4ac158041
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Daniel Friesen <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Trevor Parscal <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
