Ottomata has submitted this change and it was merged.
Change subject: List ReplicaManager JMX Kafka metrics individually
......................................................................
List ReplicaManager JMX Kafka metrics individually
Change-Id: I698441291a9ce48a61a04522fb27886a343532f8
---
M manifests/server/jmxtrans.pp
1 file changed, 26 insertions(+), 3 deletions(-)
Approvals:
Ottomata: Looks good to me, approved
jenkins-bot: Verified
diff --git a/manifests/server/jmxtrans.pp b/manifests/server/jmxtrans.pp
index 4a6987d..5d247c0 100644
--- a/manifests/server/jmxtrans.pp
+++ b/manifests/server/jmxtrans.pp
@@ -92,6 +92,11 @@
'attrs' => $kafka_rate_jmx_attrs,
},
# Per Topic Metrics
+ # These are listed separately so that that each name.topic
+ # can be keyed individually. If you used ['name', 'topic']
+ # as typeNames, the keys would be like
+ #
kafka.server.BrokerTopicMetrics.BytesInPerSec_webrequest_text.OneMinuteRate
+ # Instead of
kafka.server.BrokerTopicMetrics.BytesInPerSec.webrequest_text.OneMinuteRate
{
'name' =>
'kafka.server:type=BrokerTopicMetrics,name=BytesInPerSec,topic=*',
'resultAlias' =>
'kafka.server.BrokerTopicMetrics.BytesInPerSec',
@@ -130,12 +135,30 @@
},
# ReplicaManager Metrics
+ # These are listed separately because they don't all share the
+ # same attributes.
{
- 'name' =>
'kafka.server:type=ReplicaManager,name=*',
- 'resultAlias' => 'kafka.server.ReplicaManager',
- 'typeNames' => ['name'],
+ 'name' =>
'kafka.server:type=ReplicaManager,name=IsrExpandsPerSec',
+ 'resultAlias' =>
'kafka.server.ReplicaManager.IsrExpandsPerSec',
'attrs' => $kafka_rate_jmx_attrs,
},
+ {
+ 'name' =>
'kafka.server:type=ReplicaManager,name=IsrShrinksPerSec',
+ 'resultAlias' =>
'kafka.server.ReplicaManager.IsrShrinksPerSec',
+ 'attrs' => $kafka_rate_jmx_attrs,
+ }, {
+ 'name' =>
'kafka.server:type=ReplicaManager,name=LeaderCount',
+ 'resultAlias' =>
'kafka.server.ReplicaManager.LeaderCount',
+ 'attrs' => $kafka_value_jmx_attrs,
+ }, {
+ 'name' =>
'kafka.server:type=ReplicaManager,name=PartitionCount',
+ 'resultAlias' =>
'kafka.server.ReplicaManager.PartitionCount',
+ 'attrs' => $kafka_value_jmx_attrs,
+ }, {
+ 'name' =>
'kafka.server:type=ReplicaManager,name=UnderReplicatedPartitions',
+ 'resultAlias' =>
'kafka.server.ReplicaManager.UnderReplicatedPartitions',
+ 'attrs' => $kafka_value_jmx_attrs,
+ },
# ReplicaFetcherManager
{
--
To view, visit https://gerrit.wikimedia.org/r/231064
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I698441291a9ce48a61a04522fb27886a343532f8
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet/kafka
Gerrit-Branch: master
Gerrit-Owner: Ottomata <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
