Thiemo Mättig (WMDE) has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231248
Change subject: Drop dead code from ClaimHtmlGenerator
......................................................................
Drop dead code from ClaimHtmlGenerator
Change-Id: Id0139ffa448b30522cdc4a683b3bdd72b2ddead8
---
M view/src/ClaimHtmlGenerator.php
1 file changed, 20 insertions(+), 29 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/48/231248/1
diff --git a/view/src/ClaimHtmlGenerator.php b/view/src/ClaimHtmlGenerator.php
index 8eee28e..776aa41 100644
--- a/view/src/ClaimHtmlGenerator.php
+++ b/view/src/ClaimHtmlGenerator.php
@@ -60,54 +60,45 @@
}
/**
- * Builds and returns the HTML representing a single WikibaseEntity's
claim.
+ * Builds and returns the HTML representing a single WikibaseEntity's
statement.
*
* @since 0.4
*
- * @param Claim $claim the claim to render
+ * @param Statement $statement
* @param null|string $editSectionHtml has the html for the edit section
*
* @return string
*/
- public function getHtmlForClaim( Claim $claim, $editSectionHtml = null
) {
+ public function getHtmlForClaim( Statement $statement, $editSectionHtml
= null ) {
$mainSnakHtml = $this->snakHtmlGenerator->getSnakHtml(
- $claim->getMainSnak(),
+ $statement->getMainSnak(),
false
);
- // TODO: Resolve if-statement after concept of Claim has been
removed
- // (see https://github.com/wmde/WikibaseDataModel/pull/317)
- if ( $claim instanceof Statement ) {
- /** @var Statement $claim */
- $statementRankSerializer = new
StatementRankSerializer();
- $serializedRank = $statementRankSerializer->serialize(
$claim->getRank() );
+ $statementRankSerializer = new StatementRankSerializer();
+ $serializedRank = $statementRankSerializer->serialize(
$statement->getRank() );
- // Messages: wikibase-statementview-rank-preferred,
wikibase-statementview-rank-normal,
- // wikibase-statementview-rank-deprecated
- $rankHtml = $this->templateFactory->render(
- 'wikibase-rankselector',
- 'ui-state-disabled',
- 'wikibase-rankselector-' . $serializedRank,
- $this->getStatementRankText( $serializedRank )
- );
+ // Messages: wikibase-statementview-rank-preferred,
wikibase-statementview-rank-normal,
+ // wikibase-statementview-rank-deprecated
+ $rankHtml = $this->templateFactory->render(
+ 'wikibase-rankselector',
+ 'ui-state-disabled',
+ 'wikibase-rankselector-' . $serializedRank,
+ $this->getStatementRankText( $serializedRank )
+ );
- $referencesHeading = $this->getReferencesHeading(
$claim );
+ $referencesHeading = $this->getReferencesHeading( $statement );
- $referencesHtml = $this->getHtmlForReferences(
- $claim->getReferences()
- );
- } else {
- $rankHtml = '';
- $referencesHeading = '';
- $referencesHtml = '';
- }
+ $referencesHtml = $this->getHtmlForReferences(
+ $statement->getReferences()
+ );
return $this->templateFactory->render(
'wikibase-statementview',
- $claim->getGuid(),
+ $statement->getGuid(),
$rankHtml,
$mainSnakHtml,
- $this->getHtmlForQualifiers( $claim->getQualifiers() ),
+ $this->getHtmlForQualifiers(
$statement->getQualifiers() ),
$editSectionHtml,
$referencesHeading,
$referencesHtml
--
To view, visit https://gerrit.wikimedia.org/r/231248
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id0139ffa448b30522cdc4a683b3bdd72b2ddead8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
