jenkins-bot has submitted this change and it was merged.
Change subject: DropdownWidget: Remove additional vertical margin, for
consistency
......................................................................
DropdownWidget: Remove additional vertical margin, for consistency
No other widget used in similar context has such margin.
(Do it for SelectFileWidget, too, which clearly had it copy-pasted.)
Change-Id: I24d8868abaadf71d1c16c2ebc7f10647ab791a67
---
M src/themes/apex/widgets.less
M src/themes/mediawiki/widgets.less
2 files changed, 0 insertions(+), 4 deletions(-)
Approvals:
Catrope: Looks good to me, but someone else must approve
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index 109e717..0d126bf 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -102,7 +102,6 @@
}
.theme-oo-ui-dropdownWidget () {
- margin: 0.25em 0;
width: 100%;
max-width: 50em;
@@ -167,7 +166,6 @@
}
.theme-oo-ui-selectFileWidget () {
- margin: 0.25em 0;
width: 100%;
max-width: 50em;
diff --git a/src/themes/mediawiki/widgets.less
b/src/themes/mediawiki/widgets.less
index a83d304..87d7c18 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -98,7 +98,6 @@
}
.theme-oo-ui-dropdownWidget () {
- margin: 0.25em 0;
width: 100%;
max-width: 50em;
background: #fff;
@@ -168,7 +167,6 @@
}
.theme-oo-ui-selectFileWidget () {
- margin: 0.25em 0;
width: 100%;
max-width: 50em;
--
To view, visit https://gerrit.wikimedia.org/r/231473
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I24d8868abaadf71d1c16c2ebc7f10647ab791a67
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz DziewoĆski <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits