Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231476
Change subject: Clean up width toggle styles
......................................................................
Clean up width toggle styles
* Move styles affecting .flow-board from widget styles to
common.less so they load early enough, fixing a FOUC
where the max-width of the board changed from 850px to 1200px
* Remove unnecessary rules
** display: block; clear: left; box-sizing: border-box; on .flow-board
** display: block; float: right; set twice on expanded sidebar
* Use @medium variable
Bug: T103584
Change-Id: I48aa80fafb92e331e2143d3f72eeca131b172a57
---
M modules/styles/common.less
M modules/styles/flow/widgets/mw.flow.ui.SidebarExpandWidget.less
2 files changed, 20 insertions(+), 24 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow
refs/changes/76/231476/1
diff --git a/modules/styles/common.less b/modules/styles/common.less
index 7b473bb..0b6e774 100644
--- a/modules/styles/common.less
+++ b/modules/styles/common.less
@@ -192,12 +192,26 @@
max-width: none;
}
}
+
+ .flow-component.topic-page {
+ .flow-board {
+ float: left;
+ width: 66%;
+ max-width: 1200px;
+ padding-right: 26px;
+
+ &-expanded {
+ width: 100%;
+ max-width: none;
+ }
+ }
+ }
}
.flow-board-header-footer {
margin-top: 2em;
font-size: 0.85em;
- @media (min-width: 1165px) {
+ @media (min-width: @medium) {
margin-top: 6em;
}
}
diff --git a/modules/styles/flow/widgets/mw.flow.ui.SidebarExpandWidget.less
b/modules/styles/flow/widgets/mw.flow.ui.SidebarExpandWidget.less
index 345bfa8..82244a2 100644
--- a/modules/styles/flow/widgets/mw.flow.ui.SidebarExpandWidget.less
+++ b/modules/styles/flow/widgets/mw.flow.ui.SidebarExpandWidget.less
@@ -1,8 +1,11 @@
+@import 'flow.variables';
+
+
.flow-ui-sidebarExpandWidget {
display: none;
margin-top: 1.6em;
- @media (min-width: 1165px) {
+ @media (min-width: @medium) {
padding-left: 10px;
display: block;
float: right;
@@ -12,9 +15,7 @@
}
&-collapsed {
- @media (min-width: 1165px) {
- display: block;
- float: right;
+ @media (min-width: @medium) {
width: 24px;
margin-left: -24px;
}
@@ -25,24 +26,5 @@
}
.oo-ui-buttonElement.oo-ui-iconElement > .oo-ui-buttonElement-button >
.oo-ui-iconElement-icon.oo-ui-icon-topic-expand {
background: url( '../images/topic-expand.svg' ) no-repeat;
- }
-}
-
-.flow-component.topic-page .flow-board {
- @media (min-width: 1165px) {
- display: block;
- float: left;
- clear: left;
- width: 66%;
- box-sizing: border-box;
- max-width: 1200px;
- padding-right: 26px;
- }
-
- &-expanded {
- @media (min-width: 1165px) {
- width: 100%;
- max-width: none;
- }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/231476
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I48aa80fafb92e331e2143d3f72eeca131b172a57
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Flow
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
