Christopher Johnson (WMDE) has submitted this change and it was merged.

Change subject: moves setEvents to execute only when config option is enabled 
Bug: T107197
......................................................................


moves setEvents to execute only when config option is enabled
Bug: T107197

Change-Id: I1bbe86ea7fc07fe0bde17e5540cf6369f2c436fd
---
M src/view/burndown/SprintDataView.php
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Christopher Johnson (WMDE): Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/view/burndown/SprintDataView.php 
b/src/view/burndown/SprintDataView.php
index 2dfc6a3..dd21e42 100644
--- a/src/view/burndown/SprintDataView.php
+++ b/src/view/burndown/SprintDataView.php
@@ -44,7 +44,7 @@
     $this->setTimezone($stats);
     $this->setBefore($stats);
     $this->setTimeSeries($stats);
-    $this->setEvents($query);
+
 
     $show_burndown = PhabricatorEnv::getEnvConfig('sprint.show-burndown');
     $show_pies = PhabricatorEnv::getEnvConfig('sprint.show-pies');
@@ -110,6 +110,7 @@
 
     $show_events = PhabricatorEnv::getEnvConfig('sprint.show-events-table');
     if ($show_events == true) {
+      $this->setEvents($query);
       $event_table_view = id(new EventTableView())
           ->setProject($this->project)
           ->setViewer($this->viewer)

-- 
To view, visit https://gerrit.wikimedia.org/r/231421
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1bbe86ea7fc07fe0bde17e5540cf6369f2c436fd
Gerrit-PatchSet: 2
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) <[email protected]>
Gerrit-Reviewer: Christopher Johnson (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to