jenkins-bot has submitted this change and it was merged.
Change subject: Fix minor bug in LanguageFallbackChainFactoryTest
......................................................................
Fix minor bug in LanguageFallbackChainFactoryTest
Change-Id: Ibb61953ef381ad9f66fb6369786f94b95f55a73a
---
M lib/tests/phpunit/LanguageFallbackChainFactoryTest.php
M lib/tests/phpunit/MockRepositoryTest.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php
b/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php
index bb348f7..39346c3 100644
--- a/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php
+++ b/lib/tests/phpunit/LanguageFallbackChainFactoryTest.php
@@ -218,7 +218,7 @@
public function testNewFromContextAndLanguageCode() {
$factory = new LanguageFallbackChainFactory();
- $languageFallbackChain = $factory->newFromContext(
\RequestContext::getMain(), 'en' );
+ $languageFallbackChain =
$factory->newFromContextAndLanguageCode( \RequestContext::getMain(), 'en' );
$this->assertTrue( $languageFallbackChain instanceof
LanguageFallbackChain );
}
diff --git a/lib/tests/phpunit/MockRepositoryTest.php
b/lib/tests/phpunit/MockRepositoryTest.php
index 4c8ad93..d8910bb 100644
--- a/lib/tests/phpunit/MockRepositoryTest.php
+++ b/lib/tests/phpunit/MockRepositoryTest.php
@@ -152,7 +152,7 @@
$this->assertEquals( null, $this->repo->getItemIdForLink(
'xywiki', 'Foo' ) );
// test lookup after item modification
- $item->addSiteLink( new SiteLink( 'enwiki', 'Bar' ), 'set' );
+ $item->getSiteLinkList()->setNewSiteLink( 'enwiki', 'Bar' );
$this->repo->putEntity( $item );
$this->assertEquals( null, $this->repo->getItemIdForLink(
'enwiki', 'Foo' ) );
--
To view, visit https://gerrit.wikimedia.org/r/231245
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibb61953ef381ad9f66fb6369786f94b95f55a73a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Jeroen De Dauw <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
