jenkins-bot has submitted this change and it was merged.
Change subject: Fix for VP9/Opus transcodes: actually use Opus
......................................................................
Fix for VP9/Opus transcodes: actually use Opus
Had accidentally left off the codec setting; it was defaulting
to Vorbis but labeled as Opus. Happened to work by accident. :P
Bug: T63805
Change-Id: I71c4e7e3a2f644ff26d572af2ad7ed178ff7501a
---
M WebVideoTranscode/WebVideoTranscode.php
1 file changed, 4 insertions(+), 4 deletions(-)
Approvals:
Paladox: Looks good to me, but someone else must approve
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/WebVideoTranscode/WebVideoTranscode.php
b/WebVideoTranscode/WebVideoTranscode.php
index 7e1c35b..97b8d73 100644
--- a/WebVideoTranscode/WebVideoTranscode.php
+++ b/WebVideoTranscode/WebVideoTranscode.php
@@ -214,39 +214,39 @@
array(
'maxSize' => '640x360',
'videoBitrate' => '256',
- 'audioQuality' => '1',
'samplerate' => '48000',
'noUpscaling' => 'true',
'twopass' => 'true',
'keyframeInterval' => '128',
'bufDelay' => '256',
'videoCodec' => 'vp9',
+ 'audioCodec' => 'opus',
'type' => 'video/webm;
codecs="vp9, opus"',
),
WebVideoTranscode::ENC_VP9_480P =>
array(
'maxSize' => '854x480',
'videoBitrate' => '512',
- 'audioQuality' => '2',
'samplerate' => '48000',
'noUpscaling' => 'true',
'twopass' => 'true',
'keyframeInterval' => '128',
'bufDelay' => '256',
'videoCodec' => 'vp9',
+ 'audioCodec' => 'opus',
'type' => 'video/webm;
codecs="vp9, opus"',
),
WebVideoTranscode::ENC_VP9_720P =>
array(
'maxSize' => '1280x720',
'videoBitrate' => '1024',
- 'audioQuality' => 3,
'samplerate' => '48000',
'noUpscaling' => 'true',
'twopass' => 'true',
'keyframeInterval' => '128',
'bufDelay' => '256',
'videoCodec' => 'vp9',
+ 'audioCodec' => 'opus',
'tileColumns' => '2',
'type' => 'video/webm;
codecs="vp9, opus"',
),
@@ -254,13 +254,13 @@
array(
'maxSize' => '1920x1080',
'videoBitrate' => '2048',
- 'audioQuality' => 3,
'samplerate' => '48000',
'noUpscaling' => 'true',
'twopass' => 'true',
'keyframeInterval' => '128',
'bufDelay' => '256',
'videoCodec' => 'vp9',
+ 'audioCodec' => 'opus',
'tileColumns' => '4',
'type' => 'video/webm;
codecs="vp9, opus"',
),
--
To view, visit https://gerrit.wikimedia.org/r/231563
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71c4e7e3a2f644ff26d572af2ad7ed178ff7501a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Paladox <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
