jenkins-bot has submitted this change and it was merged.
Change subject: Define variable event
......................................................................
Define variable event
* Declare event as first function parameter.
* Move event.preventDefault() to the synchronous end of the function.
Change-Id: I813355088cbf215264dcccd474e97630915d63c5
---
M modules/ext.codeEditor.geshi.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
TheDJ: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ext.codeEditor.geshi.js b/modules/ext.codeEditor.geshi.js
index 57892a8..86a4884 100644
--- a/modules/ext.codeEditor.geshi.js
+++ b/modules/ext.codeEditor.geshi.js
@@ -89,7 +89,7 @@
} );
$save = $( '<button>' )
.text( mw.msg( 'savearticle' ) )
- .click( function () {
+ .click( function ( event ) {
// horrible hack ;)
var src, tag, api = new
mw.Api();
@@ -103,8 +103,8 @@
setupEditor( $html );
closeEditor();
- event.preventDefault();
} );
+ event.preventDefault();
} );
$cancel = $( '<button>' )
.text( 'Close' ).click( function (
event ) {
--
To view, visit https://gerrit.wikimedia.org/r/221409
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I813355088cbf215264dcccd474e97630915d63c5
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CodeEditor
Gerrit-Branch: master
Gerrit-Owner: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Gerrit Patch Uploader <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
