Ori.livneh has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231728
Change subject: Only convert boolean true/false to !0/!1
......................................................................
Only convert boolean true/false to !0/!1
Fix-up for I5ab29b686b8.
Change-Id: Ib78c628147fdb95982d6e33e0ab298584fb63d0b
---
M includes/libs/JavaScriptMinifier.php
1 file changed, 2 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/28/231728/1
diff --git a/includes/libs/JavaScriptMinifier.php
b/includes/libs/JavaScriptMinifier.php
index cb282eb..3629620 100644
--- a/includes/libs/JavaScriptMinifier.php
+++ b/includes/libs/JavaScriptMinifier.php
@@ -565,10 +565,8 @@
$out .= ' ';
$lineLength++;
}
- if( $token === 'true' ) {
- $token = '!0';
- } elseif( $token === 'false' ) {
- $token = '!1';
+ if( $type === self::TYPE_LITERAL && ( $token === 'true'
|| $token === 'false' ) ) {
+ $token = ( $token === 'true' ) ? '!0' : '!1';
}
$out .= $token;
--
To view, visit https://gerrit.wikimedia.org/r/231728
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib78c628147fdb95982d6e33e0ab298584fb63d0b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
