Ottomata has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231780
Change subject: Add param for auto.leader.rebalance.enable
......................................................................
Add param for auto.leader.rebalance.enable
Change-Id: I3981f51d45b2b9e6422f50f6892d46d1c0c97005
---
M manifests/defaults.pp
M manifests/server.pp
M templates/server.properties.erb
3 files changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet/kafka
refs/changes/80/231780/1
diff --git a/manifests/defaults.pp b/manifests/defaults.pp
index c64f1ad..d9d01ef 100644
--- a/manifests/defaults.pp
+++ b/manifests/defaults.pp
@@ -36,6 +36,7 @@
$nofiles_ulimit = 8192
$auto_create_topics_enable = false
+ $auto_leader_rebalance_enable = true
$replica_lag_time_max_ms = undef
$replica_lag_max_messages = undef
diff --git a/manifests/server.pp b/manifests/server.pp
index 57a1cc8..aa4b873 100644
--- a/manifests/server.pp
+++ b/manifests/server.pp
@@ -48,6 +48,9 @@
#
# $auto_create_topics_enable - If autocreation of topics is
allowed. Default: false
#
+# $auto_leader_rebalance_enable - If leaders should be auto rebalanced.
+# Default: true
+#
# $num_partitions - The default number of partitions per
topic.
# Default: size($log_dirs)
#
@@ -143,6 +146,7 @@
$nofiles_ulimit = $kafka::defaults::nofiles_ulimit,
$auto_create_topics_enable =
$kafka::defaults::auto_create_topics_enable,
+ $auto_leader_rebalance_enable =
$kafka::defaults::auto_leader_rebalance_enable,
$num_partitions = size($log_dirs),
$default_replication_factor = size(keys($brokers)),
diff --git a/templates/server.properties.erb b/templates/server.properties.erb
index b8dfa3f..57a5ca8 100644
--- a/templates/server.properties.erb
+++ b/templates/server.properties.erb
@@ -56,6 +56,11 @@
# and number of partitions.
auto.create.topics.enable=<%= @auto_create_topics_enable ? 'true' : 'false' %>
+# If this is enabled the controller will automatically try to balance
+# leadership for partitions among the brokers by periodically returning
+# leadership to the "preferred" replica for each partition if it is available.
+auto.leader.rebalance.enable=<%= @auto_leader_rebalance_enable %>
+
<% if @replica_lag_time_max_ms -%>
# If a follower hasn't sent any fetch requests for this window of time,
# the leader will remove the follower from ISR and treat it as dead.
--
To view, visit https://gerrit.wikimedia.org/r/231780
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3981f51d45b2b9e6422f50f6892d46d1c0c97005
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet/kafka
Gerrit-Branch: master
Gerrit-Owner: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
