Aaron Schulz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/231856

Change subject: Always call setValidationHash() in MessageCache::saveToCaches() 
* This avoids constant churn when $wgUseLocalMessageCache is set to false * 
Follow up to db464b8a847a
......................................................................

Always call setValidationHash() in MessageCache::saveToCaches()
* This avoids constant churn when $wgUseLocalMessageCache is set to false
* Follow up to db464b8a847a

Change-Id: I8da324c53527da32d09964be6c3a92176af4ee7b
---
M includes/cache/MessageCache.php
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/56/231856/1

diff --git a/includes/cache/MessageCache.php b/includes/cache/MessageCache.php
index 3f60d8c..7945c8b 100644
--- a/includes/cache/MessageCache.php
+++ b/includes/cache/MessageCache.php
@@ -639,9 +639,10 @@
                        $success = true;
                }
 
+               $this->setValidationHash( $code, $cache['HASH'] );
+
                # Save to local cache
                if ( $wgUseLocalMessageCache ) {
-                       $this->setValidationHash( $code, $cache['HASH'] );
                        $this->saveToLocalCache( $code, $cache );
                }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/231856
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8da324c53527da32d09964be6c3a92176af4ee7b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to