jenkins-bot has submitted this change and it was merged.
Change subject: mediawiki.legacy.common: don't embed legacy images
......................................................................
mediawiki.legacy.common: don't embed legacy images
This drops the /* @embed */ directive for the images referenced by the
mediawiki.legacy.common stylesheet. The images themselves and the styles which
apply them remain. They will simply not be pre-loaded as data URIs within the
stylesheet, which is fantastic because mediawiki.legacy.common is top-loaded on
all pages and embedded images make up nearly half of its weight. With this
change, the gzipped size of mediawiki.legacy.common drops from 27.6k to 15.6k.
Affected classes:
* `.mw-icon-question`: Used for tooltips generated by
Preferences::getOptionFromUser.
* `.mw-help-field-hint`: Not in use since I8e092e9d.
* `.mw-small-spinner`: Not in use since I2a2556a0.
* `.mw-ajax-loader`: Not in use.
Change-Id: I6c7e592a502ae14b9f81165f10a1d4240e592649
---
M resources/src/mediawiki.legacy/shared.css
1 file changed, 5 insertions(+), 6 deletions(-)
Approvals:
Aaron Schulz: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.legacy/shared.css
b/resources/src/mediawiki.legacy/shared.css
index ca883e6..248ea19 100644
--- a/resources/src/mediawiki.legacy/shared.css
+++ b/resources/src/mediawiki.legacy/shared.css
@@ -2,6 +2,11 @@
* CSS in this file is used by *all* skins (that have any CSS at all). Be
* careful what you put in here, since what looks good in one skin may not in
* another, but don't ignore the poor pre-Monobook users either.
+ *
+ * NOTE: The images which are referenced in this file are no longer in use in
+ * essential interface components. They should NOT be embedded, because that
+ * optimizes for the uncommon case at the cost of bloating the size of render-
+ * blocking CSS common to all pages.
*/
/* GENERAL CLASSES FOR DIRECTIONALITY SUPPORT */
@@ -265,9 +270,7 @@
* compatibility (browsers able to understand gradient syntax support
also SVG).
*
http://pauginer.tumblr.com/post/36614680636/invisible-gradient-technique */
background-image: url(images/question.png);
- /* @embed */
background-image: -webkit-linear-gradient(transparent, transparent),
url(images/question.svg);
- /* @embed */
background-image: linear-gradient(transparent, transparent),
url(images/question.svg);
background-repeat: no-repeat;
background-size: 13px 13px;
@@ -881,7 +884,6 @@
}
.mw-ajax-loader {
- /* @embed */
background-image: url(images/ajax-loader.gif);
background-position: center center;
background-repeat: no-repeat;
@@ -893,7 +895,6 @@
.mw-small-spinner {
padding: 10px !important;
margin-right: 0.6em;
- /* @embed */
background-image: url(images/spinner.gif);
background-position: center center;
background-repeat: no-repeat;
@@ -1033,7 +1034,6 @@
margin-left: 2px;
margin-bottom: -8px;
padding: 0 0 0 15px;
- /* @embed */
background-image: url(images/help-question.gif);
background-position: left center;
background-repeat: no-repeat;
@@ -1044,7 +1044,6 @@
}
.mw-help-field-hint:hover {
- /* @embed */
background-image: url(images/help-question-hover.gif);
}
--
To view, visit https://gerrit.wikimedia.org/r/231743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6c7e592a502ae14b9f81165f10a1d4240e592649
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <[email protected]>
Gerrit-Reviewer: Aaron Schulz <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: TheDJ <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
