Subramanya Sastry has uploaded a new change for review.
https://gerrit.wikimedia.org/r/231865
Change subject: Bugfix for crasher: followup to c0ec8c78
......................................................................
Bugfix for crasher: followup to c0ec8c78
* Found during rt-testing.
* This bug is exercised in cache-reuse scenarios. So, this shows up
only on pages that have multiple extension calls with the exact
same source, and at least one of those calls finish before others
are made.
* Verified fix on ruthenium, the rt-testing server (since I couldn't
reproduce this locally very likely because of network delays between
my laptop and the wmf mediawiki install).
Change-Id: I96f6f1ef1eb08ad48bc4982b5d87253a2fce0f3c
---
M lib/ext.core.ExtensionHandler.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid
refs/changes/65/231865/1
diff --git a/lib/ext.core.ExtensionHandler.js b/lib/ext.core.ExtensionHandler.js
index ad86e54..f02687a 100644
--- a/lib/ext.core.ExtensionHandler.js
+++ b/lib/ext.core.ExtensionHandler.js
@@ -84,7 +84,8 @@
env.dp('Note: trying to expand ', text);
var cacheEntry = env.batcher.parse(title, text, cb);
if (cacheEntry !== undefined) {
- cb(cacheEntry);
+ // First param is error value.
+ cb(null, cacheEntry);
} else {
parentCB ({ async: true });
}
--
To view, visit https://gerrit.wikimedia.org/r/231865
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I96f6f1ef1eb08ad48bc4982b5d87253a2fce0f3c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
