jenkins-bot has submitted this change and it was merged.
Change subject: WikidataPageBanner add banner to imagelinks
......................................................................
WikidataPageBanner add banner to imagelinks
Check which banner is valid and eligible to be added and added it to imagelinks
in addCustomBanner parser hook.
Bug: T108614
Change-Id: I23751b51f7c937e8c368351d1cb071ceae50b7ee
---
M includes/WikidataPageBanner.hooks.php
1 file changed, 16 insertions(+), 0 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/WikidataPageBanner.hooks.php
b/includes/WikidataPageBanner.hooks.php
index ca892a4..5f330f9 100644
--- a/includes/WikidataPageBanner.hooks.php
+++ b/includes/WikidataPageBanner.hooks.php
@@ -161,6 +161,22 @@
$paramsForBannerTemplate['name'] = $bannername;
// Set 'wpb-banner-options' property for generating
banner later
$parser->getOutput()->setProperty(
'wpb-banner-options', $paramsForBannerTemplate );
+
+ // add the valid banner to image links
+ // @FIXME:Since bannernames which are to be added are
generated here, getBannerHtml can
+ // be cleaned to only accept a valid title object
pointing to a banner file
+ // Default banner is not added to imagelinks as that is
the property of this extension
+ // and is uniform across all pages
+ $wikidataBanner =
$wpbFunctionsClass::getWikidataBanner( $title );
+ $bannerTitle = null;
+ if ( $wpbFunctionsClass::getImageUrl(
$paramsForBannerTemplate['name'] ) !== null ) {
+ $bannerTitle = Title::makeTitleSafe( NS_FILE,
$paramsForBannerTemplate['name'] );
+ } elseif ( $wpbFunctionsClass::getImageUrl(
$wikidataBanner ) !== null ) {
+ $bannerTitle = Title::makeTitleSafe( NS_FILE,
$wikidataBanner );
+ }
+ if ( $bannerTitle !== null ) {
+ $parser->fetchFileAndTitle( $bannerTitle );
+ }
}
}
--
To view, visit https://gerrit.wikimedia.org/r/230643
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I23751b51f7c937e8c368351d1cb071ceae50b7ee
Gerrit-PatchSet: 10
Gerrit-Project: mediawiki/extensions/WikidataPageBanner
Gerrit-Branch: master
Gerrit-Owner: Sumit <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Sumit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
